fix: avoid changing import list if old name is new name

browniebroke · Oct 16, 2020 · c3fecb3 · c3fecb3
1 parent 0372933
commit c3fecb3
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/django_codemod/visitors/base.py b/django_codemod/visitors/base.py
@@ -105,10 +105,11 @@ def gen_new_imported_names(
         for import_alias in old_names:
             if not self.old_name or import_alias.evaluated_name == self.old_name:
                 self.context.scratch[self.ctx_key_imported_as] = import_alias.asname
-                if self.simple_rename:
-                    self.add_new_import(import_alias.evaluated_name)
-            else:
-                yield import_alias
+                if self.rename_from != self.rename_to:
+                    if self.simple_rename:
+                        self.add_new_import(import_alias.evaluated_name)
+                    continue
+            yield import_alias
 
     def tidy_new_imported_names(self, new_names):
         """Tidy up the updated list of imports"""