Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Add batching when uploading models #344

Merged
merged 2 commits into from
May 25, 2023
Merged

[Fix] Add batching when uploading models #344

merged 2 commits into from
May 25, 2023

Conversation

jared-rimmer
Copy link
Member

Overview

  • In release 2.4.0 was added the all_results JSON object to upload_models.sql
  • This results in large queries that are too big for BigQuery which we saw for tests.
  • This PR uses the exact same logic for tests but in models.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

#343

Outstanding questions

  • Need confirmation on what the correct batch size should be

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests May 25, 2023 14:44 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests May 25, 2023 14:44 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests May 25, 2023 14:44 — with GitHub Actions Failure
glsdown
glsdown approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@glsdown glsdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 this is the issue

macros/upload_results.sql Outdated Show resolved Hide resolved
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 14:55 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 14:55 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 14:55 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer changed the title [FEAT] Add batching when uploading models [Fix] Add batching when uploading models May 25, 2023
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 15:04 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 15:04 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 15:04 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 15:04 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 15:05 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 25, 2023 15:05 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer merged commit b7d45ac into main May 25, 2023
@jared-rimmer jared-rimmer deleted the feat/implement-batching-in-upload-models branch May 25, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glsdown glsdown glsdown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jared-rimmer @glsdown