PE-357: Fix externally filed issue against this repository #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdmedlin1
changed the title
blshukla
reviewed
Dec 17, 2024
| @@ -6,12 +6,13 @@ function main() | |||
| enableLDWS() | |||
| ' Enable SSH | |||
There was a problem hiding this comment.
Please format/align the comments and method calls correctly.
There was a problem hiding this comment.
Does this not need the app.use block added in the templates/cra-template-brightsign-app/template/src/server/index.js file above?
| @@ -8,13 +8,13 @@ function main() | |||
| ' Enable SSH | |||
| enableSSH() | |||
|
|
|||
| ' Initialize roNodeJs with path or correct filename, whether webpack is used or not. | |||
| node_js = CreateObject("roNodeJs", "sd:/dist/backend.js", {message_port: mp, node_arguments: ["--inspect=0.0.0.0:2999"], arguments: []}) | |||
There was a problem hiding this comment.
Is moving this line before creating the HTML widget creation, part of the solution?
|
Can you add more details what is the problem and how the issues are resolved by the changes here? It's not very obvious from the code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Here is the filed issue: #22