Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix in autorun, html instantiated before nodejs #27

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aleBranching
Copy link

📝 Description

Issue: Url to Github Issue

📋 List of Changes

  • Please provide a concise list of the main changes.
  • Change autorun.brs to instantiate the html after the nodejs server is started

🧪 Steps to Test

  • If uploading the code to brightsign it will now load html correctly
  1. Step 1

Notes to the Reviewer

📸 Screenshots

✔️ Dev Complete Checklist

  • PR template filled out
  • Change is tested by submitter
  • PR follows all linting and coding standards
  • Github Issue exists (if applicable)
  • Team member has been assigned
  • At least one commit message is in Conventional Commit format

@aleBranching
Copy link
Author

First time making a pull request, I realise I should have ran yarn install to get the pr template to fill out. Should have run linting but it's just lines being moved;

@ethan-arreya
Copy link

Confirmed that I had the same issue testing a blank app until I moved the same lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants