Cleanup #11
Merged
Cleanup #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update root readme for clarity * update example readmes for build, debug, deploy
bhastings1019
requested review from
lherlein,
blshukla,
jdmedlin1 and
diegobrsign
blshukla
reviewed
Apr 9, 2024
blshukla
approved these changes
Apr 9, 2024
jdmedlin1
reviewed
Apr 11, 2024
|
|
||
| ### Features | ||
|
|
||
| * Add tests for templates and nodejs examples ([#10](https://github.com/brightsign/dev-cookbook/issues/10)) ([3fe286c](https://github.com/brightsign/dev-cookbook/commit/3fe286c92a32e841b1900403d3f783565a1e9407)) |
There was a problem hiding this comment.
This bullet starts with a capitalized letter. The others don't. Not huge, just nit picking.
jdmedlin1
reviewed
Apr 11, 2024
jdmedlin1
reviewed
Apr 11, 2024
jdmedlin1
reviewed
Apr 11, 2024
jdmedlin1
reviewed
Apr 11, 2024
jdmedlin1
reviewed
Apr 11, 2024
jdmedlin1
reviewed
Apr 11, 2024
Co-authored-by: jdmedlin1 <[email protected]> Signed-off-by: diegobrsign <[email protected]>
diegobrsign
approved these changes
Apr 16, 2024
Signed-off-by: diegobrsign <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Issue: PE-208
📋 List of Changes
✔️ Dev Complete Checklist