Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for trailing comma in arrays. #16

Merged
merged 2 commits into from
Feb 7, 2021
Merged

Add support for trailing comma in arrays. #16

merged 2 commits into from
Feb 7, 2021

Conversation

ADmad
Copy link
Contributor

@ADmad ADmad commented Feb 6, 2021

Trailing comma won't be added to inlined arrays even if trailing comma option being enabled.

@ADmad
Add support for trailing comma in arrays.
92eca82 
Trailing comma won't be added to inlined arrays even if the related option being enabled.
@BenMorel
Copy link
Member

BenMorel commented Feb 6, 2021

Hi, thanks for your PR! Looks good to me.

Could you please:

  • Update the README to mention the new option
  • Mention in both the README and in the docblock that this option does not apply to inline arrays

@BenMorel BenMorel merged commit ed08975 into brick:master Feb 7, 2021
@BenMorel
Copy link
Member

BenMorel commented Feb 7, 2021

Released as 0.3.4. Thank you!

@ADmad ADmad deleted the feature/trailling-comma-in-array branch February 7, 2021 23:00
@dereuromark dereuromark mentioned this pull request Oct 8, 2023
Merged
BenMorel pushed a commit that referenced this pull request May 10, 2024
@ADmad @BenMorel
Add support for trailing comma in arrays. (#16)
eaa8614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ADmad @BenMorel