Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LICENSE files in the published codespan-reporting crate #365

Open
danakj opened this issue Sep 24, 2024 · 0 comments
Open

Include LICENSE files in the published codespan-reporting crate #365

danakj opened this issue Sep 24, 2024 · 0 comments

Comments

@danakj
Copy link

danakj commented Sep 24, 2024

While the Cargo.toml specifies a license (or licenses), crates also typically include a copy of that license (or licenses) as LICENSE files. This github repo contains the license files but the codespan-reporting crate does not.

Can the appropriate license files be included in the codespan-reporting crate?

As a consumer of third party open source libraries, Chromium is aiming to ensure we include the license files in our own source tree for all of our third-party dependencies, and the codespan-reporting crate is one of a few for which they are missing. Chromium issue: crbug.com/369075726

danakj added a commit to danakj/codespan that referenced this issue Sep 25, 2024
Symlinks are added up to the license files in the repository
root for the codespan, codespan-lsp, and codespan-reporting
crates.

This ensures projects that include the source code for this project
will also get a copy of the licenses.

Fixes brendanzab#365.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant