Skip to content
This repository has been archived by the owner on Sep 6, 2020. It is now read-only.

Verify command has unclear return codes #116

Closed
mbrodala opened this issue Nov 1, 2015 · 0 comments
Closed

Verify command has unclear return codes #116

mbrodala opened this issue Nov 1, 2015 · 0 comments

Comments

@mbrodala
Copy link
Contributor

mbrodala commented Nov 1, 2015

The codes returned by the verify command are rather odd currently:

  1. The path is not a file or does not exist: code 1 (fine)
  2. The Phar passed verification: code 1 (should be 0 instead)
  3. The Phar failed verification: code 0 (should be at least 1 instead)

The return codes for 2. and 3. do not match usual CLI behavior and should be fixed.

mbrodala added a commit to mbrodala/box2 that referenced this issue Nov 1, 2015
Return 0 on success and 1 on error.

Fixes box-project#116
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant