Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing typescript property declaration #438

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

Cordazar
Copy link
Contributor

The method getEngineName exists both in the project and the official docs. It's just missing in the typescript declaration file.

The method getEngineName exists both in the project and the official docs. It's just missing in the typescript declaration file.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 961

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.52%

Totals Coverage Status
Change from base Build 950: 0.0%
Covered Lines: 576
Relevant Lines: 589

💛 - Coveralls

Copy link
Collaborator

@lancedikson lancedikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Cordazar, for your contribution! 🙏

@lancedikson lancedikson merged commit a6317d2 into bowser-js:production Sep 12, 2020
@lancedikson
Copy link
Collaborator

Oh, I just noticed that it was merged to production. I'll cherry-pick your commit to master for the upcoming release.

@lancedikson
Copy link
Collaborator

It's been released in 2.11.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants