Add tsdb query functions with end duration parameter. #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport end time Adds more general versions of Over() and Band() that support an eduration parameter to set the end time of the query, like with q() (#2297)
|
cmd/bosun/expr/expr_test.go needs a fmt but other than that I think this good |
added 4 commits
September 21, 2018 17:49
|
Thanks, hadn't spotted the gofmt version differences! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two functions for querying against openTSDB –
overQueryandbandQuery. These functions slightly generalise the existingoverandbandfunctions to include an end duration parametereduration, which specifies when a query should end, as is done withq. This enables queries for a historical distribution that does not include recent outliers – related discussion in #2297 .The existing
overandbandfunctions are changed to wrap the more general functions. The undocumented and very relatedshiftBandfunction was found during this work, and is added to the documentation.The third commit f61259a refactors the functions to reuse
bandTSDB, asshiftBandused this function to achieve comparable functionality toover.Tests were written based on the existing function of
over,bandandshiftBandto ensure same behaviour remains.