Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate smb:// URLs #1631 #1957

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheLazron
Copy link
Contributor

Description

Added logic from borg that validates the url against certain regex patterns. Borg code wont invalidate smb:// urls, so introduced change to one of the regex patterns

Related Issue

#1631

Motivation and Context

Additional check for Repository URL, as using smb:// format resulted in crashes as per #1628

How Has This Been Tested?

using smb:// repository URLs gave an error like other unsupported ones

Screenshots (if appropriate):

a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@TheLazron TheLazron marked this pull request as ready for review March 7, 2024 10:01
@real-yfprojects
Copy link
Collaborator

Why was Vorta freezing in the fist case? Is there no simpler solution to fixing that? This PR introduces quite some lines of code that need to be maintained. Additionally you do not have the copyright for these lines so proper attribution and license compatibility have to be checked.

@m3nu m3nu marked this pull request as draft October 20, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants