Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pyfuse3 as an alternative lowlevel fuse implementation #5430

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

ThomasWaldmann
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #5430 into master will decrease coverage by 0.07%.
The diff coverage is 79.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5430      +/-   ##
==========================================
- Coverage   83.69%   83.62%   -0.08%     
==========================================
  Files          37       38       +1     
  Lines        9957     9982      +25     
  Branches     1656     1661       +5     
==========================================
+ Hits         8334     8347      +13     
- Misses       1142     1151       +9     
- Partials      481      484       +3     
Impacted Files Coverage Δ
src/borg/archiver.py 81.26% <33.33%> (-0.01%) ⬇️
src/borg/fuse_impl.py 84.61% <84.61%> (ø)
src/borg/archive.py 82.64% <0.00%> (-0.62%) ⬇️
src/borg/helpers/parseformat.py 89.16% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56c816...cebc5bf. Read the comment docs.

Copy link
Contributor

@Gu1nness Gu1nness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I would add a test where BORG_FUSE_IMPL is set to an empty variable to ensure that it crashed the way we want to avoid regressions in the future.
  • The documentation needs to be updated to be indented the way we should.
  • I have run all the tests and it seems to be working (fuse2 and fuse3)

docs/usage/general/environment.rst.inc Outdated Show resolved Hide resolved
src/borg/fuse_impl.py Show resolved Hide resolved
@ThomasWaldmann ThomasWaldmann changed the title WIP: add pyfuse3 as an alternative lowlevel fuse implementation add pyfuse3 as an alternative lowlevel fuse implementation Oct 21, 2020
@ThomasWaldmann
Copy link
Member Author

Squashed the fixup, reword another commit comment. Will merge after tests complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants