-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Apple iOS and improve detection of arm architecture #2
Conversation
set version to 8.0.0 in case of __arm64 (allows check for armv8 targets)
Good patch. BTW it would be nice to have ios simulator detection macro too. |
iOS simulator detection is already there:
|
Well, it's true (: But I think first people's step will be:
|
OK, now I see what you mean. I should probably introduce |
@@ -0,0 +1,51 @@ | |||
/* | |||
Copyright Rene Rivera 2008-2013 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me to be able to add any new code to a Boost library there must be correct copyright attribution. Please update with your copyright.
I've changed everything as requested by the review. Is the patch OK now? |
Add support for Apple iOS and improve detection of arm architecture. Thanks to Franz Detro for the changes.
Hi, what about |
@ruslo: This Maybe @grafikrobot can comment on this... |
There's the concept of "platforms" that would likely fit the different iOS On Wed, Apr 30, 2014 at 1:55 AM, Franz Detro [email protected]:
-- Rene Rivera |
Sounds nice |
I've added a new predef
BOOST_OS_IOS
for Apple iOS based on detection of the preprocessor macro__ENVIRONMENT_IPHONE_OS_VERSION_MIN_REQUIRED__
.Additionally, I've extended the detection for
BOOST_ARCH_ARM
with a check for__arm64
, a preprocessor macro which is set by the Apple clang compiler for the new ARMv8 64bit architecture.Both changes enable the use of
boost::predef
with projects targeting Apple iOS for 32 and 64bit arm architectures.It would be great if this patch can make it into the next boost release!