Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use install- features instead of package module #70

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

grisumbras
Copy link
Member

@grisumbras grisumbras commented May 16, 2024

The core of this change is swithcing from using the package module to install- features. This potentially allows property-set-based install prefixes and proper staging. In addition, there's some simplification done by switching from generate targets to make targets. Also, all helper features are removed and <flags> is used instead.

PS-based installation and proper staging doesn't work yet because /boost/headers//install doesn't use install- features.

One note: most install-X features don't check corresponding --X options. Only install-prefix does. This is probably an oversight, so I should change that in b2 project.

@grisumbras grisumbras force-pushed the use-install-features branch 3 times, most recently from b7cf99d to dbef53f Compare May 17, 2024 14:04
@grisumbras grisumbras force-pushed the use-install-features branch from dbef53f to fa98e51 Compare May 17, 2024 14:58
@grisumbras
Copy link
Member Author

grisumbras commented May 20, 2024

Update: bfgroup/b2#392 makes install-X features check --X options.

@grisumbras grisumbras marked this pull request as ready for review June 12, 2024 11:29
@grisumbras
Copy link
Member Author

Related issues: #34, #46. Both should be fixed if this and boostorg/headers#1 are merged.

@grisumbras
Copy link
Member Author

#32: while writing this PR I also wondered why DLLs aren't installed into bindir.

@pdimov
Copy link
Member

pdimov commented Jun 12, 2024

They are, but only on Cygwin for some reason.

Is this ready to merge at this point, replicating the old behavior 1:1?

@grisumbras
Copy link
Member Author

Should be. It does work on my machine ™️

@pdimov pdimov merged commit 8cc082e into boostorg:develop Jun 12, 2024
95 checks passed
@pdimov
Copy link
Member

pdimov commented Jun 12, 2024

To move DLLs into bindir, we'll probably have to introduce dlldir so that people have a way to get the old behavior back.

@pdimov
Copy link
Member

pdimov commented Jun 12, 2024

mkdir: cannot create directory ‘/usr/local/lib/cmake’: Permission denied

@pdimov
Copy link
Member

pdimov commented Jun 12, 2024

Why did this stop working? The PR run passed.

@pdimov
Copy link
Member

pdimov commented Jun 12, 2024

Maybe I needed to merge the headers PR as well?

@grisumbras
Copy link
Member Author

The headers PR shouldn't be necessary. I'll re-push and check.

@grisumbras
Copy link
Member Author

Ok, something else definitely broke. I'll investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants