Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CMakeLists #2954

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Refactor CMakeLists #2954

merged 6 commits into from
Nov 25, 2024

Conversation

ashtum
Copy link
Collaborator

@ashtum ashtum commented Nov 20, 2024

No description provided.

@ashtum ashtum force-pushed the refactor-CMakeLists branch 7 times, most recently from 6578b23 to 2064606 Compare November 21, 2024 12:48
@ashtum ashtum requested a review from vinniefalco November 21, 2024 12:50
@ashtum ashtum force-pushed the refactor-CMakeLists branch 4 times, most recently from 947c619 to f68f7e6 Compare November 22, 2024 21:27
@ashtum ashtum force-pushed the refactor-CMakeLists branch 2 times, most recently from 2d96059 to cafd112 Compare November 23, 2024 06:23
@ashtum ashtum force-pushed the refactor-CMakeLists branch from cafd112 to bb54264 Compare November 23, 2024 07:00
@ashtum ashtum force-pushed the refactor-CMakeLists branch 9 times, most recently from 8bcf41a to e632104 Compare November 23, 2024 11:11
@ashtum ashtum force-pushed the refactor-CMakeLists branch from e632104 to 25fa114 Compare November 23, 2024 11:34
@vinniefalco
Copy link
Member

This is looking great now. If you could please change the README.md to include updated instructions for building the 32 bit and the 64 bit solutions. I used:

cmake -G "Visual Studio 17 2022" -A x64 -B bin64 -DBUILD_TESTING=ON -DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake -DVCPKG_CHAINLOAD_TOOLCHAIN_FILE="C:/Users/vinnie/src/boost/libs/http_io/cmake/toolchains/msvc.cmake"

@ashtum
Copy link
Collaborator Author

ashtum commented Nov 24, 2024

This is looking great now. If you could please change the README.md to include updated instructions for building the 32 bit and the 64 bit solutions. I used:

cmake -G "Visual Studio 17 2022" -A x64 -B bin64 -DBUILD_TESTING=ON -DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake -DVCPKG_CHAINLOAD_TOOLCHAIN_FILE="C:/Users/vinnie/src/boost/libs/http_io/cmake/toolchains/msvc.cmake"

There's no need to set BUILD_TESTING anymore. When Boost.Beast is the root project, it includes CTest, which automatically sets BUILD_TESTING:

if (BOOST_BEAST_IS_ROOT)
    include(CTest)
endif ()
option(BOOST_BEAST_BUILD_TESTS "Build boost::beast tests" ${BUILD_TESTING})

@vinniefalco
Copy link
Member

Don't tell me that just edit the command line as you see fit, and insert it into the README

@ashtum
Copy link
Collaborator Author

ashtum commented Nov 24, 2024

Don't tell me that just edit the command line as you see fit, and insert it into the README

It's already in the README, do you want me to change C:/boost/libs/beast/cmake/toolchains/msvc.cmake to C:/Users/vinnie/src/boost/libs/beast/cmake/toolchains/msvc.cmake?

@vinniefalco
Copy link
Member

There is no file "C:/boost/libs/beast/cmake/toolchains/msvc.cmake". You could refer to this path instead:
https://github.com/boostorg/url/blob/develop/cmake/toolchains/msvc.cmake

@ashtum ashtum merged commit c00cca3 into boostorg:develop Nov 25, 2024
27 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants