Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if probability is in [0, 1] #10

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

check if probability is in [0, 1] #10

wants to merge 1 commit into from

Conversation

e-kwsm
Copy link

@e-kwsm e-kwsm commented Jan 10, 2017

  • include/boost/accumulators/statistics/extended_p_square.hpp
  • include/boost/accumulators/statistics/extended_p_square_quantile.hpp
  • include/boost/accumulators/statistics/extended_p_square_quantile.hpp
  • include/boost/accumulators/statistics/p_square_quantile.hpp
  • include/boost/accumulators/statistics/peaks_over_threshold.hpp
  • include/boost/accumulators/statistics/pot_quantile.hpp
  • include/boost/accumulators/statistics/pot_tail_mean.hpp
  • include/boost/accumulators/statistics/tail_mean.hpp
  • include/boost/accumulators/statistics/tail_quantile.hpp
  • include/boost/accumulators/statistics/tail_variate_means.hpp
  • include/boost/accumulators/statistics/weighted_extended_p_square.hpp
  • include/boost/accumulators/statistics/weighted_peaks_over_threshold.hpp
  • include/boost/accumulators/statistics/weighted_tail_mean.hpp
  • include/boost/accumulators/statistics/weighted_tail_quantile.hpp
  • include/boost/accumulators/statistics/weighted_tail_variate_means.hpp

@e-kwsm
check if probability is in [0, 1]
534fcba 
* include/boost/accumulators/statistics/extended_p_square.hpp
* include/boost/accumulators/statistics/extended_p_square_quantile.hpp
* include/boost/accumulators/statistics/extended_p_square_quantile.hpp
* include/boost/accumulators/statistics/p_square_quantile.hpp
* include/boost/accumulators/statistics/peaks_over_threshold.hpp
* include/boost/accumulators/statistics/pot_quantile.hpp
* include/boost/accumulators/statistics/pot_tail_mean.hpp
* include/boost/accumulators/statistics/tail_mean.hpp
* include/boost/accumulators/statistics/tail_quantile.hpp
* include/boost/accumulators/statistics/tail_variate_means.hpp
* include/boost/accumulators/statistics/weighted_extended_p_square.hpp
* include/boost/accumulators/statistics/weighted_peaks_over_threshold.hpp
* include/boost/accumulators/statistics/weighted_tail_mean.hpp
* include/boost/accumulators/statistics/weighted_tail_quantile.hpp
* include/boost/accumulators/statistics/weighted_tail_variate_means.hpp
@yuvalif
Copy link
Contributor

yuvalif commented Dec 24, 2018

@e-kwsm don't think you can introduce exceptions into existing code like that. also, there is the runtime check cost. Instead, would recommend adding documentation on the behavior in case of invalid probability values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-kwsm @yuvalif