Fix path specification passed to AC_CHECK_PROG when checking for FileCheck #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Check The set of locations in which `AC_CHECK_PROG` looks for a program is passed to the macro as a colon-separated path specification. However, in the invocation of `AC_CHECK_PROG` for `FileCheck`, this specification is preceded by an extra `path = `, which causes the first location to be interpreted as `path = $CLANG_PREFIX/bin` rather than `$CLANG_PREFIX/bin`. This causes the check to fail, even if the file `$CLANG_PREFIX/bin/FileCheck` exists and is executable. Removing the prefix makes the check work as expected. Signed-off-by: Andi Drebes <[email protected]>
|
Just saw that somebody mentioned the same in #96. |
bondhugula
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set of locations in which
AC_CHECK_PROGlooks for a program is passed to the macro as a colon-separated path specification.However, in the invocation of
AC_CHECK_PROGforFileCheck, this specification is preceded by an extrapath =, which causes the first location to be interpreted aspath = $CLANG_PREFIX/binrather than$CLANG_PREFIX/bin. This causes the check to fail, even if the file$CLANG_PREFIX/bin/FileCheckexists and is executable.Removing the prefix makes the check work as expected.