Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger layout invalidation on widget display #64

Conversation

peytondmurray
Copy link
Contributor

Summary

This PR triggers layout invalidation when the widget is displayed, closing #58. See that issue for a complete discussion and examples.

Changes

  • This change modifies how ipywidgets are displayed by allowing an onDisplay callback to be passed to the WidgetManager.render function which triggers when the view's displayed event is emitted.
  • Back in the IPyWidgetView, the widget manager's render function is passed a callback which invalidates the layout.
  • Also modified the "dev" mode script to avoid minimizing the bundle, making debugging easier.

@peytondmurray
Copy link
Contributor Author

Sounds like while this solves the minimal working example, it doesn't address all use cases. Moving back into draft.

@peytondmurray peytondmurray marked this pull request as draft November 2, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant