Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream 20231106 #86

Merged
merged 257 commits into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
257 commits
Select commit Hold shift + click to select a range
b00a3d1
Add test for GetAllClaims
ajsutton Oct 23, 2023
571b89f
Update stub to support batch calls.
ajsutton Oct 23, 2023
bb475da
Use package alias
ajsutton Oct 23, 2023
2f8c136
config for optimism-goerli
tremarkley Oct 25, 2023
d7ee471
indexer.metric.prefix
hamdiallam Oct 25, 2023
ec1deb6
remove unnecessary changes
hamdiallam Oct 26, 2023
4d5375b
periphery deploy configs for op chains
tremarkley Oct 26, 2023
ff2b887
op-e2e: Split e2e tests into two executors
ajsutton Oct 27, 2023
7d51ff3
op-e2e: Move some tests back to executor 0.
ajsutton Oct 27, 2023
04b4611
op-e2e: Use unsigned ints to avoid negatives.
ajsutton Oct 27, 2023
d979236
contracts-bedrock: goerli protocol versions config
tynes Oct 27, 2023
344e063
op-node: enable all network options by default
protolambda Oct 25, 2023
6b21778
op-node,op-program: update network flag error format
protolambda Oct 27, 2023
d75c85b
op-node: add extra-networks deprecaction warning log
protolambda Oct 27, 2023
26fdfb8
feat(proxyd): support eip-1898 in tag rewritting
felipe-op Oct 27, 2023
72fc3f0
remove etl batch metrics
hamdiallam Oct 27, 2023
e973741
report latest header of the connected client
hamdiallam Oct 27, 2023
2abe032
updated indexed l1/l2 heights in the bridge processor
hamdiallam Oct 27, 2023
1c3f642
interval_failures name
hamdiallam Oct 27, 2023
cd8f629
Merge branch 'develop' into aj/multicaller
ajsutton Oct 30, 2023
7a28c35
batching: Give ContractCall more standalone utility.
ajsutton Oct 30, 2023
194c739
batching: Add more unit tests.
ajsutton Oct 30, 2023
53a60ce
Persist Rust toolchain in final `ci-builder` image
clabby Oct 30, 2023
db016e6
op-e2e: Remove manual test code.
ajsutton Oct 30, 2023
dbdcde3
Make MaxSpanBatchFieldSize equal to MaxRLPBytesPerChannel
pcw109550 Oct 16, 2023
177b78c
Harden Span batch field size check
pcw109550 Oct 16, 2023
c6d3901
Add tests for span batch field size check
pcw109550 Oct 16, 2023
c0d92e6
Add comments for l1Blocks field of batch queue
pcw109550 Oct 16, 2023
51866cd
Update spec for span batch field limit
pcw109550 Oct 16, 2023
f4e2450
Rename variable and explanations span batch limit
pcw109550 Oct 17, 2023
70e060c
op-node/derive: use require instead of assert in span-batch tests
pcw109550 Oct 20, 2023
5b3f8b0
Merge pull request #7751 from testinprod-io/tip/span-batch-limit
protolambda Oct 30, 2023
72cd648
op-node: Span Batch type/encoding/decoding refactor
pcw109550 Oct 10, 2023
9f9cf61
op-node: reduce batch inner type encode/decode methods to just one way
protolambda Oct 30, 2023
4cc340a
ci: disable codecov comments on zero diff
Inphi Oct 30, 2023
8ac11e3
Merge pull request #7926 from ethereum-optimism/inphi/cc
trianglesphere Oct 30, 2023
babe5e7
Merge pull request #7752 from testinprod-io/tip/span-batch-types-refa…
protolambda Oct 30, 2023
6600e97
header traversal nits
hamdiallam Oct 30, 2023
c3efa31
Merge pull request #7858 from ethereum-optimism/10-25-indexer.metric.…
hamdiallam Oct 30, 2023
0f49412
Merge pull request #7908 from ethereum-optimism/felipe/proxyd-eip1898
felipe-op Oct 30, 2023
3f3ad34
op-node: Hide rethDB option
trianglesphere Oct 30, 2023
81a04c1
Merge pull request #7918 from ethereum-optimism/cl/rustc-ci
mslipper Oct 30, 2023
006ed38
Merge pull request #7894 from ethereum-optimism/aj/e2e-groups
protolambda Oct 30, 2023
0d93adc
Merge pull request #7934 from ethereum-optimism/jg/hide_rethdb
trianglesphere Oct 30, 2023
895ccc9
build(deps-dev): bump eslint-plugin-unicorn from 48.0.1 to 49.0.0
dependabot[bot] Oct 30, 2023
89ef8cd
build(deps-dev): bump @typescript-eslint/eslint-plugin
dependabot[bot] Oct 30, 2023
32d0a49
build(deps): bump viem from 1.18.0 to 1.18.1
dependabot[bot] Oct 30, 2023
b428230
build(deps-dev): bump abitype from 0.10.1 to 0.10.2
dependabot[bot] Oct 30, 2023
2220797
build(deps): bump merkletreejs from 0.3.10 to 0.3.11
dependabot[bot] Oct 30, 2023
a51fd20
op-batcher: fix test RNG data flake
protolambda Oct 30, 2023
19fc020
Merge pull request #7944 from ethereum-optimism/fix-batcher-flake
sebastianst Oct 30, 2023
cfcb147
Add span batch e2e tests
ImTei Sep 18, 2023
aec1466
Fix flaky e2e test
ImTei Oct 27, 2023
210492c
Implement span batch atomicity during chain derivation
ImTei Oct 26, 2023
79c1c5a
Add comments in batch queue
ImTei Oct 30, 2023
8a33c02
Merge pull request #7856 from ethereum-optimism/extra-networks
trianglesphere Oct 30, 2023
d72dbe3
Rename safeHead to parent
ImTei Oct 30, 2023
3e16cd7
ci: fix e2e span batch test pre-requisite jobs
protolambda Oct 30, 2023
6bace49
[indexer.api.add_withdrawal_hash] Added cross-domain msg hash to API …
Oct 30, 2023
53f54e4
op-node: Enable Canyon on Goerli & Sepolia via superchain registry
trianglesphere Oct 30, 2023
240340b
[indexer.api.add_withdrawal_hash] verify message hash not nil
Oct 30, 2023
1e641e9
[indexer.api.add_withdrawal_hash] Remove .vscode
Oct 30, 2023
da7fb49
Merge branch 'develop' of https://github.com/epociask/optimism into i…
Oct 30, 2023
96a24cc
Merge pull request #7946 from ethereum-optimism/jg/enable_canyon
trianglesphere Oct 30, 2023
18f6d63
[indexer.api.add_withdrawal_hash] better code comments and variable n…
Oct 31, 2023
290fe11
[indexer.api.add_withdrawal_hash] update client bindings
Oct 31, 2023
ce93b94
Fix op-program to get output root from specified block number
ImTei Oct 31, 2023
fc6daa7
[indexer.api.add_withdrawal_hash] update client bindings
Oct 31, 2023
8f59b11
Add PendingSafeL2 to SyncStatus
ImTei Oct 31, 2023
7005d12
Fix TestStopStartBatcher to wait for processing full batch
ImTei Oct 31, 2023
861678b
[indexer.api.add_withdrawal_hash] Adding code comment
Oct 31, 2023
54e3cfe
Add commets for advancing epoch
ImTei Oct 31, 2023
249d9e7
batches_test refactoring
ImTei Oct 30, 2023
590ec9b
ci: solc building requires xlarge
tynes Oct 31, 2023
ed77e6a
Merge pull request #7943 from ethereum-optimism/dependabot/npm_and_ya…
tynes Oct 31, 2023
4179c39
Merge pull request #7941 from ethereum-optimism/dependabot/npm_and_ya…
tynes Oct 31, 2023
59d7a8a
Merge pull request #7940 from ethereum-optimism/dependabot/npm_and_ya…
tynes Oct 31, 2023
e4b6580
contracts-bedrock: simplify safecall test
tynes Oct 31, 2023
3468586
build(deps-dev): bump typedoc from 0.25.2 to 0.25.3
dependabot[bot] Oct 31, 2023
840338d
Merge pull request #7960 from ethereum-optimism/ctb/safecall-test
tynes Oct 31, 2023
ebe2f2f
indexer: refactor service lifecycle to start/stop resoures more cleanly
protolambda Oct 31, 2023
81eef9b
Merge pull request #7936 from ethereum-optimism/dependabot/npm_and_ya…
tynes Oct 31, 2023
79a8b1d
Merge pull request #7937 from ethereum-optimism/dependabot/npm_and_ya…
tynes Oct 31, 2023
f775915
build(deps-dev): bump @typescript-eslint/parser from 6.9.0 to 6.9.1
dependabot[bot] Oct 31, 2023
fd03dd8
Merge pull request #7939 from ethereum-optimism/dependabot/npm_and_ya…
tynes Oct 31, 2023
ec4c4f5
contracts-bedrock: make `implSalt()` internal
tynes Oct 31, 2023
7f70dd7
contracts-bedrock: update in memory deploy config
tynes Oct 31, 2023
4376aaa
contracts-bedrock: update solidity deploy config
tynes Oct 31, 2023
c1d06ca
build(deps): bump @sentry/node from 7.75.0 to 7.77.0
dependabot[bot] Oct 31, 2023
7287289
[indexer.api.add_withdrawal_hash] changed variable naming
Oct 31, 2023
9bfaf92
Merge pull request #7938 from ethereum-optimism/dependabot/npm_and_ya…
tynes Oct 31, 2023
961c966
contracts-bedrock: fuzz message passer
tynes Oct 31, 2023
a809274
Merge pull request #7966 from ethereum-optimism/dependabot/npm_and_ya…
tynes Oct 31, 2023
7b2cb34
contracts-bedrock: virtual setup in deploy script
tynes Oct 31, 2023
0eb27a9
docker: Fix golang-docker target
ajsutton Oct 31, 2023
fae4e07
Fix batcher panic
mdehoog Oct 31, 2023
87a0644
op-node: span-batch test log level tweak, minor test-vector fix
protolambda Oct 31, 2023
f666235
Add test
mdehoog Oct 31, 2023
58c8b1f
Merge pull request #7953 from testinprod-io/tip/batches-test-refactoring
protolambda Nov 1, 2023
bcdfa0b
Merge pull request #7971 from ethereum-optimism/aj/fix-golang-docker
ajsutton Nov 1, 2023
ad0bdd6
Merge pull request #7975 from mdehoog/michael/batcher-panic
ajsutton Nov 1, 2023
8b1df75
op-node: Check l1 inclusion time for span batch
pcw109550 Oct 24, 2023
57a0209
specs: Add span batch hardfork rule
pcw109550 Oct 24, 2023
6629996
Use L1 origin block time for Span batch hard fork activation check
ImTei Nov 1, 2023
5a444e4
Merge pull request #7970 from ethereum-optimism/ctb/deploy-script-vir…
tynes Nov 1, 2023
f5b0470
Merge pull request #7964 from ethereum-optimism/ctb/solidity-deploy-c…
tynes Nov 1, 2023
3144311
Merge pull request #7962 from ethereum-optimism/ctb/internal-impl-salt
tynes Nov 1, 2023
405cb36
Merge pull request #7963 from ethereum-optimism/feat/deploy-cfg
tynes Nov 1, 2023
c24298e
Merge pull request #7969 from ethereum-optimism/ctb/message-passer-fuzz
tynes Nov 1, 2023
77817d9
Merge branch 'develop' of https://github.com/epociask/optimism into i…
Nov 1, 2023
9cbb9fb
contracts-bedrock: modularize mocks
tynes Oct 31, 2023
eeea9ed
op-bindings: regenerate
tynes Oct 31, 2023
5f41b96
lint: fix
tynes Oct 31, 2023
b0895c0
contracts-bedrock: delete dead file
tynes Nov 1, 2023
54f9a68
Merge pull request #7968 from ethereum-optimism/ctb/modularize-mocks
tynes Nov 1, 2023
b375237
contracts-bedrock: modularize the `AlphabetVM`
tynes Nov 1, 2023
3d21f9f
lint: fix
tynes Nov 1, 2023
14f84ea
Merge pull request #7986 from ethereum-optimism/ctb/modularize-alphab…
tynes Nov 1, 2023
db1ef01
Merge pull request #7901 from ethereum-optimism/feat/protocol-version…
tynes Nov 1, 2023
389a805
contracts-bedrock: modularize test mocks
tynes Nov 1, 2023
1f0c753
op-bindings: regenerate
tynes Nov 1, 2023
c8544df
lint: fix
tynes Nov 1, 2023
2aad178
Merge pull request #7831 from ethereum-optimism/harry/faucet_deployment
tynes Nov 1, 2023
c4d9b85
Merge pull request #7988 from ethereum-optimism/ctb/more-modularize-t…
tynes Nov 1, 2023
189fa9d
contracts-bedrock: delete `CheckBalanceHigh` dripcheck
tynes Nov 1, 2023
258dc4c
op-bindings: rebuild
tynes Nov 1, 2023
13faa91
contracts-bedrock: fully deprecate semver
tynes Oct 28, 2023
27e1f49
contracts-bedrock: delete dead comments
tynes Nov 1, 2023
9e6c95b
contracts-bedrock: fix semver lock
tynes Nov 1, 2023
a3d3ae3
module console.log cleanup
maurelian Oct 30, 2023
6e090f8
specs: Improvements to liveness checking specs
maurelian Oct 30, 2023
4abf2d9
contracts-bedrock: better comment for deployer `name()(string)`
tynes Nov 1, 2023
e8f93e9
contracts-bedrock: fix compiler error
tynes Nov 1, 2023
518b4af
Merge pull request #7990 from ethereum-optimism/ctb/delete-dead-check…
tynes Nov 1, 2023
6f57e9c
Merge pull request #7914 from ethereum-optimism/fix/deprecate-semver
tynes Nov 1, 2023
7305996
contracts-bedrock: fuzz optimism portal
tynes Nov 1, 2023
056407f
op-bindings: regenerathttps://github.com/ethereum-optimism/optimism/p…
tynes Nov 1, 2023
97e9734
contracts-bedrock: deduplicate tests
tynes Nov 1, 2023
490983b
lint: fix
tynes Nov 1, 2023
efdf61f
contracts-bedock: gas snapshot
tynes Nov 1, 2023
78210d4
contracts-bedrock: deal uint128 max
tynes Nov 1, 2023
a31e727
Merge pull request #7987 from ethereum-optimism/ctb/deploy-name-comment
tynes Nov 1, 2023
8728c76
build(deps): bump viem from 1.18.1 to 1.18.2
dependabot[bot] Nov 1, 2023
8abd5df
Merge branch 'develop' into aj/multicaller
ajsutton Nov 1, 2023
5cd3bcb
op-upgrade: log invalid deploy-config error
Inphi Nov 1, 2023
b4e09c3
op-bindings: Rebuild
trianglesphere Nov 1, 2023
0a5076e
Remove weth9 local build
trianglesphere Nov 1, 2023
e1c5bb1
Merge pull request #8005 from ethereum-optimism/jg/fix_bindings_build
ajsutton Nov 2, 2023
e10a265
batching: Use input instead of data when making eth_Call requests
ajsutton Nov 1, 2023
e5f8d68
Merge remote-tracking branch 'origin/develop' into aj/multicaller
ajsutton Nov 2, 2023
fe32ae5
Merge pull request #7945 from epociask/indexer.api.add_withdrawal_hash
hamdiallam Nov 2, 2023
3c10d0c
Merge pull request #7712 from ethereum-optimism/aj/multicaller
ajsutton Nov 2, 2023
f082bd0
challenger: Move DisputeGameFactory to use new approach to contract r…
ajsutton Nov 2, 2023
283375c
fix #8010
kafeikui Nov 2, 2023
14f6508
Merge pull request #7996 from ethereum-optimism/inphi/chain-nit
tynes Nov 2, 2023
a4a7bbc
bindings: regenerate
tynes Nov 2, 2023
8795d0f
Merge pull request #7995 from ethereum-optimism/dependabot/npm_and_ya…
tynes Nov 2, 2023
ed158ed
Merge pull request #8011 from kafeikui/fix-wait-for-rpc-server
tynes Nov 2, 2023
1271109
Merge pull request #7935 from ethereum-optimism/jm/log-cleanup
tynes Nov 2, 2023
3be62ed
indexer: lifecycle refactor review fixes
protolambda Nov 2, 2023
b58f6b4
op-service: interrupt handling improvement
protolambda Nov 2, 2023
972fcab
ci: ignore code coverage in script contracts
Inphi Nov 1, 2023
2add4a5
Merge pull request #7992 from ethereum-optimism/inphi/cov-script
Inphi Nov 2, 2023
07d22c8
Merge pull request #7985 from epociask/indexer.risk_mitigations
hamdiallam Nov 2, 2023
a490dde
Merge branch 'develop' into indexer-lifecycle
protolambda Nov 2, 2023
46f00fe
contracts-bedrock: deal better
tynes Nov 2, 2023
43efe7f
op-service: fix typo in comment
protolambda Nov 2, 2023
d04582b
contracts-bedrock: gas snapshot
tynes Nov 2, 2023
413aac1
Merge pull request #7991 from ethereum-optimism/ctb/portal-fuzzing
tynes Nov 2, 2023
48962ac
op-node: static-peers list local-peer check and flag description update
protolambda Nov 2, 2023
b253cd0
proxyd: configurable IP rate limit header
danyalprout Nov 2, 2023
14d154d
op-node: static-peers test
protolambda Nov 2, 2023
e6c5afa
Merge pull request #8014 from ethereum-optimism/filter-static-peers
protolambda Nov 2, 2023
beea937
build(deps-dev): bump hardhat from 2.18.3 to 2.19.0
dependabot[bot] Nov 2, 2023
8e7b9f7
build(deps): bump @ethereumjs/rlp from 5.0.0 to 5.0.1
dependabot[bot] Nov 2, 2023
c12c9f4
build(deps): bump viem from 1.18.2 to 1.18.3
dependabot[bot] Nov 2, 2023
1c46496
chore: Make paths references DRY
Nov 2, 2023
fea98f4
Merge pull request #7961 from ethereum-optimism/indexer-lifecycle
protolambda Nov 2, 2023
a850928
specs: clarify span-batch validation rules include upgrade activation…
protolambda Nov 2, 2023
6646032
specs: improve wording of upgrade activation rules
protolambda Nov 2, 2023
2006da2
Merge pull request #7813 from testinprod-io/tip/span-batch-hard-fork-…
protolambda Nov 2, 2023
d3bf13b
op-node: attributes queue reset state for consistency
protolambda Nov 2, 2023
90848b2
op-e2e/actions: use interface in batcher for l2 block ref access
protolambda Nov 2, 2023
3e890bb
Merge pull request #7867 from testinprod-io/tip/span-batch-atomicity
protolambda Nov 3, 2023
ce1b1e3
Usage of 'Immutable' for variables storing keccak hashes
0xScratch Nov 3, 2023
8bf2ab6
Merge pull request #8018 from ethereum-optimism/dependabot/npm_and_ya…
tynes Nov 3, 2023
0f3ef43
Merge pull request #8017 from ethereum-optimism/dependabot/npm_and_ya…
tynes Nov 3, 2023
03cef1e
Merge pull request #8015 from ethereum-optimism/dependabot/npm_and_ya…
tynes Nov 3, 2023
3ef2413
contracts-bedrock: lite foundry profile
tynes Nov 3, 2023
9575b73
Merge pull request #8028 from ethereum-optimism/ctb/lite-foundry-profile
tynes Nov 3, 2023
d705143
contracts-bedrock: simplify merkle trie setup
tynes Nov 3, 2023
6fd31c7
contracts-bedrock: migrate ffi interface
tynes Nov 3, 2023
0ea7755
contracts-bedrock: gas-snapshot
tynes Nov 3, 2023
85d9328
Merge pull request #8029 from ethereum-optimism/ctb/simplify-merkle-test
tynes Nov 3, 2023
80bbf24
contracts-bedrock: simplify test
tynes Nov 3, 2023
c9412a9
contracts-bedrock: simplify rlp tests
tynes Nov 3, 2023
9d8678f
contracts-bedrock: 1967 helper version
tynes Nov 3, 2023
0205424
fix(fm-test-services): Use lockfile in docker test
Oct 30, 2023
6441c44
contracts-bedrock: simplify CrossDomainOwnable test
tynes Nov 3, 2023
52ab367
contracts-bedrock: fix
tynes Nov 3, 2023
51a4521
Merge pull request #8020 from ethereum-optimism/11-02-chore_Make_path…
tynes Nov 3, 2023
ec7b2cf
contracts-bedrock: cleanup
tynes Nov 3, 2023
1d4afbf
Merge pull request #8032 from ethereum-optimism/ctb/1967-helper-version
tynes Nov 3, 2023
68e840c
Merge pull request #8030 from ethereum-optimism/ctb/deployer-list-sim…
tynes Nov 3, 2023
f9b9f5c
Merge pull request #8031 from ethereum-optimism/ctb/rlp-test-simplify
tynes Nov 3, 2023
76c4420
Merge pull request #8024 from Aryan9592/patch-1
Inphi Nov 3, 2023
813b8f9
Merge pull request #8019 from danyalprout/override-rate-limit-ip-header
felipe-op Nov 3, 2023
40a9ae2
Merge pull request #8033 from ethereum-optimism/ctb/simplify-cdo
tynes Nov 3, 2023
d911a8c
build(deps): bump viem from 1.18.3 to 1.18.4
dependabot[bot] Nov 3, 2023
5623db6
Merge pull request #8009 from ethereum-optimism/aj/game-factory-multi…
ajsutton Nov 4, 2023
8443712
Merge pull request #7930 from ethereum-optimism/10-30-fix_fm-test-ser…
roninjin10 Nov 4, 2023
a6d211a
Merge pull request #8036 from ethereum-optimism/dependabot/npm_and_ya…
tynes Nov 4, 2023
126e8ad
op-challenger: Remove AbsolutePreState from TraceProvider
ajsutton Nov 6, 2023
fe5f61e
op-challenger: Remove claim loader
ajsutton Nov 6, 2023
09b509c
build(deps): bump github.com/jackc/pgx/v5 from 5.4.3 to 5.5.0
dependabot[bot] Nov 6, 2023
586f7f4
build(deps): bump golang.org/x/sync from 0.4.0 to 0.5.0
dependabot[bot] Nov 6, 2023
74206f5
Merge pull request #8051 from ethereum-optimism/dependabot/go_modules…
tynes Nov 6, 2023
5c21b79
build(deps): bump golang.org/x/time from 0.3.0 to 0.4.0
dependabot[bot] Nov 6, 2023
5e1722f
Merge pull request #8049 from ethereum-optimism/dependabot/go_modules…
tynes Nov 6, 2023
fe7d01b
Merge pull request #8050 from ethereum-optimism/dependabot/go_modules…
tynes Nov 6, 2023
7bc7ce3
build(deps): bump github.com/libp2p/go-libp2p-pubsub
dependabot[bot] Nov 6, 2023
9b93101
op-node: remove deprecated `Pretty()` call
tynes Nov 6, 2023
0ccf39b
contracts-bedrock: foundry d85718785859dc0b5a095d2302d1a20ec06ab77a
tynes Nov 6, 2023
fbbde31
Merge pull request #8052 from ethereum-optimism/feat/new-foundry
tynes Nov 6, 2023
081eebd
contracts-bedrock: decouple magic number in test
tynes Nov 6, 2023
0a47b6c
Merge pull request #7959 from ethereum-optimism/ci/xlarge-solc
mslipper Nov 6, 2023
95672da
Merge pull request #8053 from ethereum-optimism/ctb/fdg-decouple
tynes Nov 6, 2023
2743c1a
Merge pull request #8042 from ethereum-optimism/aj/remove-absolute-pr…
Inphi Nov 6, 2023
6e890fa
contracts-bedrock: test deploy script
tynes Oct 25, 2023
cecb3c1
contracts-bedrock: modularize L2 setup
tynes Nov 1, 2023
123409e
op-bindings: regenerate
tynes Nov 3, 2023
eb5cf57
contracts-bedrock: cleanup
tynes Nov 6, 2023
71df3b9
contracts-bedrock: gas-snapshot
tynes Nov 6, 2023
ae85ba8
invariant-docs: regenerate
tynes Nov 6, 2023
4f2aaa3
contracts-bedrock: fix review nits
tynes Nov 6, 2023
88eee4f
Merge pull request #8044 from ethereum-optimism/aj/remove-loader
ajsutton Nov 6, 2023
cef1a24
contracts-bedrock: lint
tynes Nov 6, 2023
202db3a
Merge pull request #8048 from ethereum-optimism/dependabot/go_modules…
trianglesphere Nov 6, 2023
5741303
Merge pull request #7928 from ethereum-optimism/feat/ctb-test-deploy-2
tynes Nov 6, 2023
0600b0a
Merge branch 'develop' into merge-upstream-20231106
boyuan-chen Nov 6, 2023
75a8a3b
Fix go mod and pnpm lock
boyuan-chen Nov 6, 2023
924cbc9
Update gas snapshot
boyuan-chen Nov 7, 2023
31722fe
Increase instance size
boyuan-chen Nov 7, 2023
1d3f9b9
Increase resource class
boyuan-chen Nov 7, 2023
caf93f5
Fix boba-bindings
boyuan-chen Nov 7, 2023
8d0018e
Fix op-bindings
boyuan-chen Nov 7, 2023
db63129
Fix bindings and increase machine size
boyuan-chen Nov 7, 2023
5974e3f
Fix command
boyuan-chen Nov 7, 2023
b516173
Merge branch 'develop' into merge-upstream-20231106
boyuan-chen Nov 7, 2023
66a138f
Merge branch 'develop' into merge-upstream-20231106
boyuan-chen Nov 8, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ jobs:
op-bindings-build:
docker:
- image: <<pipeline.parameters.ci_builder_image>>
resource_class: large
resource_class: xlarge
steps:
- checkout
- run:
Expand Down
42 changes: 21 additions & 21 deletions packages/contracts-bedrock/.gas-snapshot
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ AttestationStationTest:test_attest_bulk_succeeds() (gas: 544387)
AttestationStationTest:test_attest_individual_succeeds() (gas: 472850)
AttestationStationTest:test_attest_single_succeeds() (gas: 491962)
BlockOracle_Test:test_checkpointAndLoad_succeeds() (gas: 58396)
BlockOracle_Test:test_load_noBlockHash_reverts() (gas: 12827)
BlockOracle_Test:test_load_noBlockHash_reverts() (gas: 13681)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with these changing values? How did you generate them? I've not had to modify these before, so might be worth adding to the doc?

Copy link
Author

@boyuan-chen boyuan-chen Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why these values change, but we can use pnpm gas-snapshot to generate it. However, the result on my MAC is different from what we have from CI. I have to manually overwrite some gas usages. According to this foundry-rs/foundry#4917 , the seed might be different.

Copy link
Author

@boyuan-chen boyuan-chen Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, most of changes are from the upstream.

Bytes_slice_Test:test_slice_acrossMultipleWords_works() (gas: 9413)
Bytes_slice_Test:test_slice_acrossWords_works() (gas: 1430)
Bytes_slice_Test:test_slice_fromNonZeroIdx_works() (gas: 17240)
Expand Down Expand Up @@ -47,8 +47,8 @@ CrossDomainOwnableThroughPortal_Test:test_depositTransaction_crossDomainOwner_su
CrossDomainOwnable_Test:test_onlyOwner_notOwner_reverts() (gas: 10597)
CrossDomainOwnable_Test:test_onlyOwner_succeeds() (gas: 34883)
DelayedVetoable_Getters_Test:test_getters() (gas: 24620)
DelayedVetoable_Getters_TestFail:test_getters_notZeroAddress_reverts() (gas: 31275)
DelayedVetoable_HandleCall_TestFail:test_handleCall_unauthorizedInitiation_reverts() (gas: 13589)
DelayedVetoable_Getters_TestFail:test_getters_notZeroAddress_reverts() (gas: 36289)
DelayedVetoable_HandleCall_TestFail:test_handleCall_unauthorizedInitiation_reverts() (gas: 15165)
DeployerWhitelist_Test:test_owner_succeeds() (gas: 7582)
DeployerWhitelist_Test:test_storageSlots_succeeds() (gas: 33395)
DisputeGameFactory_Owner_Test:test_owner_succeeds() (gas: 12611)
Expand Down Expand Up @@ -130,12 +130,12 @@ FaultDisputeGame_Test:test_resolve_teamDeathmatch_succeeds() (gas: 443413)
FaultDisputeGame_Test:test_rootClaim_succeeds() (gas: 8247)
FeeVault_Test:test_constructor_baseFeeVault_succeeds() (gas: 17450)
FeeVault_Test:test_constructor_l1FeeVault_succeeds() (gas: 17418)
GasBenchMark_L1CrossDomainMessenger:test_sendMessage_benchmark_0() (gas: 354468)
GasBenchMark_L1CrossDomainMessenger:test_sendMessage_benchmark_1() (gas: 2952718)
GasBenchMark_L1StandardBridge_Deposit:test_depositERC20_benchmark_0() (gas: 544971)
GasBenchMark_L1StandardBridge_Deposit:test_depositERC20_benchmark_1() (gas: 4057141)
GasBenchMark_L1StandardBridge_Deposit:test_depositETH_benchmark_0() (gas: 446205)
GasBenchMark_L1StandardBridge_Deposit:test_depositETH_benchmark_1() (gas: 3491932)
GasBenchMark_L1CrossDomainMessenger:test_sendMessage_benchmark_0() (gas: 354446)
GasBenchMark_L1CrossDomainMessenger:test_sendMessage_benchmark_1() (gas: 2952696)
GasBenchMark_L1StandardBridge_Deposit:test_depositERC20_benchmark_0() (gas: 544949)
GasBenchMark_L1StandardBridge_Deposit:test_depositERC20_benchmark_1() (gas: 4057119)
GasBenchMark_L1StandardBridge_Deposit:test_depositETH_benchmark_0() (gas: 446183)
GasBenchMark_L1StandardBridge_Deposit:test_depositETH_benchmark_1() (gas: 3491910)
GasBenchMark_L1StandardBridge_Finalize:test_finalizeETHWithdrawal_benchmark() (gas: 45337)
GasBenchMark_L2OutputOracle:test_proposeL2Output_benchmark() (gas: 88797)
GasBenchMark_OptimismPortal:test_depositTransaction_benchmark() (gas: 68320)
Expand Down Expand Up @@ -183,7 +183,7 @@ L1CrossDomainMessenger_Test:test_relayMessage_v2_reverts() (gas: 12410)
L1CrossDomainMessenger_Test:test_replayMessage_withValue_reverts() (gas: 33134)
L1CrossDomainMessenger_Test:test_sendMessage_succeeds() (gas: 392934)
L1CrossDomainMessenger_Test:test_sendMessage_twice_succeeds() (gas: 1669270)
L1CrossDomainMessenger_Test:test_xDomainMessageSender_reset_succeeds() (gas: 87096)
L1CrossDomainMessenger_Test:test_xDomainMessageSender_reset_succeeds() (gas: 87957)
L1CrossDomainMessenger_Test:test_xDomainSender_notSet_reverts() (gas: 24282)
L1ERC721Bridge_Test:test_bridgeERC721To_localTokenZeroAddress_reverts() (gas: 62759)
L1ERC721Bridge_Test:test_bridgeERC721To_remoteTokenZeroAddress_reverts() (gas: 37333)
Expand Down Expand Up @@ -226,7 +226,7 @@ L2CrossDomainMessenger_Test:test_relayMessage_toSystemContract_reverts() (gas: 3
L2CrossDomainMessenger_Test:test_relayMessage_v2_reverts() (gas: 11756)
L2CrossDomainMessenger_Test:test_sendMessage_succeeds() (gas: 124025)
L2CrossDomainMessenger_Test:test_sendMessage_twice_succeeds() (gas: 135887)
L2CrossDomainMessenger_Test:test_xDomainMessageSender_reset_succeeds() (gas: 48452)
L2CrossDomainMessenger_Test:test_xDomainMessageSender_reset_succeeds() (gas: 49311)
L2CrossDomainMessenger_Test:test_xDomainSender_senderNotSet_reverts() (gas: 10686)
L2ERC721Bridge_Test:test_bridgeERC721To_localTokenZeroAddress_reverts() (gas: 26498)
L2ERC721Bridge_Test:test_bridgeERC721To_remoteTokenZeroAddress_reverts() (gas: 21814)
Expand Down Expand Up @@ -259,12 +259,12 @@ L2OutputOracle_deleteOutputs_Test:test_deleteL2Outputs_ifNotChallenger_reverts()
L2OutputOracle_deleteOutputs_Test:test_deleteL2Outputs_nonExistent_reverts() (gas: 117047)
L2OutputOracle_deleteOutputs_Test:test_deleteOutputs_multipleOutputs_succeeds() (gas: 318177)
L2OutputOracle_deleteOutputs_Test:test_deleteOutputs_singleOutput_succeeds() (gas: 193280)
L2OutputOracle_getter_Test:test_computeL2Timestamp_succeeds() (gas: 43693)
L2OutputOracle_getter_Test:test_computeL2Timestamp_succeeds() (gas: 44553)
L2OutputOracle_getter_Test:test_getL2OutputIndexAfter_multipleOutputsExist_succeeds() (gas: 277454)
L2OutputOracle_getter_Test:test_getL2OutputIndexAfter_noOutputsExis_reverts() (gas: 17937)
L2OutputOracle_getter_Test:test_getL2OutputIndexAfter_previousBlock_succeeds() (gas: 103541)
L2OutputOracle_getter_Test:test_getL2OutputIndexAfter_sameBlock_succeeds() (gas: 103449)
L2OutputOracle_getter_Test:test_getL2Output_succeeds() (gas: 109065)
L2OutputOracle_getter_Test:test_getL2Output_succeeds() (gas: 109931)
L2OutputOracle_getter_Test:test_latestBlockNumber_succeeds() (gas: 104504)
L2OutputOracle_getter_Test:test_nextBlockNumber_succeeds() (gas: 17492)
L2OutputOracle_proposeL2Output_Test:test_proposeL2Output_emptyOutput_reverts() (gas: 34188)
Expand Down Expand Up @@ -490,7 +490,7 @@ OptimismPortal_Test:test_constructor_succeeds() (gas: 33476)
OptimismPortal_Test:test_depositTransaction_contractCreation_reverts() (gas: 14300)
OptimismPortal_Test:test_depositTransaction_largeData_reverts() (gas: 512218)
OptimismPortal_Test:test_depositTransaction_smallGasLimit_reverts() (gas: 14556)
OptimismPortal_Test:test_isOutputFinalized_succeeds() (gas: 126771)
OptimismPortal_Test:test_isOutputFinalized_succeeds() (gas: 127639)
OptimismPortal_Test:test_minimumGasLimit_succeeds() (gas: 17661)
OptimismPortal_Test:test_pause_onlyGuardian_reverts() (gas: 24487)
OptimismPortal_Test:test_pause_succeeds() (gas: 27329)
Expand Down Expand Up @@ -554,7 +554,7 @@ ProtocolVersions_Initialize_Test:test_initialize_events_succeeds() (gas: 41623)
ProtocolVersions_Initialize_Test:test_initialize_values_succeeds() (gas: 45046)
ProtocolVersions_Setters_TestFail:test_setRecommended_notOwner_reverts() (gas: 15553)
ProtocolVersions_Setters_TestFail:test_setRequired_notOwner_reverts() (gas: 15587)
ProxyAdmin_Test:test_chugsplashChangeProxyAdmin_succeeds() (gas: 35586)
ProxyAdmin_Test:test_chugsplashChangeProxyAdmin_succeeds() (gas: 36440)
ProxyAdmin_Test:test_chugsplashGetProxyAdmin_succeeds() (gas: 15675)
ProxyAdmin_Test:test_chugsplashGetProxyImplementation_succeeds() (gas: 51084)
ProxyAdmin_Test:test_chugsplashUpgradeAndCall_succeeds() (gas: 82311)
Expand All @@ -564,7 +564,7 @@ ProxyAdmin_Test:test_delegateResolvedGetProxyAdmin_succeeds() (gas: 17691)
ProxyAdmin_Test:test_delegateResolvedGetProxyImplementation_succeeds() (gas: 62028)
ProxyAdmin_Test:test_delegateResolvedUpgradeAndCall_succeeds() (gas: 98039)
ProxyAdmin_Test:test_delegateResolvedUpgrade_succeeds() (gas: 58482)
ProxyAdmin_Test:test_erc1967ChangeProxyAdmin_succeeds() (gas: 33820)
ProxyAdmin_Test:test_erc1967ChangeProxyAdmin_succeeds() (gas: 34674)
ProxyAdmin_Test:test_erc1967GetProxyAdmin_succeeds() (gas: 15616)
ProxyAdmin_Test:test_erc1967GetProxyImplementation_succeeds() (gas: 52073)
ProxyAdmin_Test:test_erc1967UpgradeAndCall_succeeds() (gas: 78971)
Expand All @@ -582,9 +582,9 @@ Proxy_Test:test_implementationKey_succeeds() (gas: 20911)
Proxy_Test:test_implementation_isZeroAddress_reverts() (gas: 47628)
Proxy_Test:test_implementation_zeroAddressCaller_succeeds() (gas: 14752)
Proxy_Test:test_ownerKey_succeeds() (gas: 19067)
Proxy_Test:test_ownerProxyCall_notAdmin_succeeds() (gas: 34623)
Proxy_Test:test_ownerProxyCall_notAdmin_succeeds() (gas: 35477)
Proxy_Test:test_proxyCallToImp_notAdmin_succeeds() (gas: 30010)
Proxy_Test:test_upgradeToAndCall_functionDoesNotExist_reverts() (gas: 104567)
Proxy_Test:test_upgradeToAndCall_functionDoesNotExist_reverts() (gas: 107980)
Proxy_Test:test_upgradeToAndCall_isPayable_succeeds() (gas: 53744)
Proxy_Test:test_upgradeToAndCall_succeeds() (gas: 125192)
Proxy_Test:test_upgradeTo_clashingFunctionSignatures_succeeds() (gas: 101363)
Expand Down Expand Up @@ -679,7 +679,7 @@ SystemConfig_Initialize_Test:test_initialize_events_succeeds() (gas: 88188)
SystemConfig_Initialize_Test:test_initialize_startBlockNoop_reverts() (gas: 77218)
SystemConfig_Initialize_Test:test_initialize_startBlockOverride_succeeds() (gas: 81116)
SystemConfig_Initialize_Test:test_initialize_values_succeeds() (gas: 88546)
SystemConfig_Initialize_TestFail:test_initialize_lowGasLimit_reverts() (gas: 58306)
SystemConfig_Initialize_TestFail:test_initialize_lowGasLimit_reverts() (gas: 59900)
SystemConfig_Setters_TestFail:test_setBatcherHash_notOwner_reverts() (gas: 15675)
SystemConfig_Setters_TestFail:test_setGasConfig_notOwner_reverts() (gas: 15644)
SystemConfig_Setters_TestFail:test_setGasLimit_notOwner_reverts() (gas: 15743)
Expand All @@ -690,9 +690,9 @@ SystemConfig_Setters_TestFail:test_setResourceConfig_notOwner_reverts() (gas: 16
SystemConfig_Setters_TestFail:test_setResourceConfig_zeroDenominator_reverts() (gas: 18629)
SystemConfig_Setters_TestFail:test_setUnsafeBlockSigner_notOwner_reverts() (gas: 15658)
TransactorTest:test_call_succeeds() (gas: 26709)
TransactorTest:test_call_unauthorized_reverts() (gas: 16543)
TransactorTest:test_call_unauthorized_reverts() (gas: 18117)
TransactorTest:test_constructor_succeeds() (gas: 9739)
TransactorTest:test_delegateCall_succeeds() (gas: 20909)
TransactorTest:test_delegateCall_unauthorized_reverts() (gas: 16550)
TransactorTest:test_delegateCall_unauthorized_reverts() (gas: 18124)
TransferOnionTest:test_constructor_succeeds() (gas: 564855)
TransferOnionTest:test_unwrap_succeeds() (gas: 724955)