Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dangling urfavcli v1 reference #68

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

jyellick
Copy link

The upstream has moved onto urfavcli v2, but we are holding onto an old file because we have not migrated yet, that still references v1. This isn't the end of the world, but it creates an unnecessary diff in our go.mod files. Since v2 is mostly compatible with v1, simply changing the import is sufficient to migrate in this case.

The upstream has moved onto urfavcli v2, but we are holding onto an old
file because we have not migrated yet, that still references v1.  This
isn't the end of the world, but it creates an unnecessary diff in our
go.mod files.  Since v2 is _mostly_ compatible with v1, simply changing
the import is sufficient to migrate in this case.
@jyellick jyellick marked this pull request as ready for review October 11, 2023 15:19
@jyellick jyellick requested a review from boyuan-chen October 11, 2023 15:20
@jyellick jyellick merged commit fa988fb into develop Oct 11, 2023
@jyellick jyellick deleted the jyellick/convert-urfavcli-v1 branch October 11, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants