Update boba bindings #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the latest Erigon seems to create many more symbol conflicts for the binding generation. This commit takes the approach of simply detecting duplicate type names and function names, and removing them from the AST. This is certainly a hack, but easier than trying to maintain things as a fork upstream.
boyuan-chen
approved these changes
Oct 5, 2023
mmontour1306
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
boba-bindings/go.modandop-erigon/go.modto reference our latest version of the Erigon fork.Because the newer version creates many conflicting symbols in the bindings generation, the generation code has been modified to track what type names and function names have already been generated, and to delete any new instances of these names from subsequent generated files. A warning is emitted to help users notice this is going on.