Add AWS credential #281
Merged
Add AWS credential #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #281 +/- ##
========================================
Coverage 66.65% 66.65%
========================================
Files 56 56
Lines 4666 4666
========================================
Hits 3110 3110
Misses 1384 1384
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. |
jyellick
approved these changes
Dec 3, 2024
ops/scripts/aws_config
Outdated
| @@ -0,0 +1,2 @@ | |||
| [profile BobaGCP] | |||
There was a problem hiding this comment.
A bit of a nit, I don't think we necessarily need to include 'Boba' here, I'd think simply calling this the "GCP" profile would be good enough. Presumably if someone is overwriting the aws config already, they would simply overwrite this file
mmontour1306
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Add associated issues, tickets, docs URL here.
Overview
Describe what your Pull Request is about in a few sentences.
Add aws credential to image