Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semgrep #269

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix semgrep #269

merged 1 commit into from
Oct 28, 2024

Conversation

boyuan-chen
Copy link

πŸ“‹ Add associated issues, tickets, docs URL here.

Overview

The fix is tested.

~/Documents/GitHub/boba.nosync enable-TestRequiredProtocolVersionChangeAndHalt* ❯ just semgrep                                                                                                                                                                                                    02:54:36 PM
semgrep scan --config=.semgrep --error .

β”Œβ”€β”€β”€β”€ β—‹β—‹β—‹ ────┐
β”‚ Semgrep CLI β”‚
β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜

                                                                                                                        
Scanning 3801 files (only git-tracked) with 8 Code rules:
            
  CODE RULES
  Scanning 670 files with 8 solidity rules.
                    
  SUPPLY CHAIN RULES
                  
  No rules to run.
                  
          
  PROGRESS
   
  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00                                                                                                                        
                
                
β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”
β”‚ Scan Summary β”‚
β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜
Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Partially scanned: 10 files only partially analyzed due to parsing or internal Semgrep errors
  Scan skipped: 23 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 8 rules on 670 files: 0 findings.

✨ If Semgrep missed a finding, please send us feedback to let us know!
   See https://semgrep.dev/docs/reporting-false-negatives/

@boyuan-chen boyuan-chen marked this pull request as ready for review October 25, 2024 21:57
@boyuan-chen boyuan-chen merged commit cdba9b2 into develop Oct 28, 2024
44 checks passed
@boyuan-chen boyuan-chen deleted the fix-semgrep branch October 28, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants