Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back external test for erigon #266

Merged
merged 8 commits into from
Oct 24, 2024

Conversation

boyuan-chen
Copy link

@boyuan-chen boyuan-chen commented Oct 23, 2024

📋 Add associated issues, tickets, docs URL here.

Overview

These tests are disabled and the erigon needs to be patched to support these tests:

"TestSendRawTransactionConditionalEnabled": "TODO, this new feature should be added to Erigon",
"TestSendRawTransactionConditionalTxForwarding": "TODO, this new feature should be added to Erigon",
"TestEIP1559Params": "TODO, this new feature should be added to Erigon",
"TestRequiredProtocolVersionChangeAndHalt": "TODO, this new feature should be added to Erigon"

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.86%. Comparing base (6d8c00d) to head (90a928e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           merge-upstream-20241022     #266   +/-   ##
========================================================
  Coverage                    64.86%   64.86%           
========================================================
  Files                           54       54           
  Lines                         4460     4460           
========================================================
  Hits                          2893     2893           
  Misses                        1391     1391           
  Partials                       176      176           
Flag Coverage Δ
cannon-go-tests 64.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@boyuan-chen boyuan-chen marked this pull request as ready for review October 24, 2024 19:50
@boyuan-chen boyuan-chen merged commit 4144db7 into merge-upstream-20241022 Oct 24, 2024
43 of 44 checks passed
@boyuan-chen boyuan-chen deleted the enable-external-erigon-tests branch October 24, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants