-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fetchPrice example, reorganized HC docs #247
Conversation
Need to ask about |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #247 +/- ##
========================================
Coverage 78.10% 78.10%
========================================
Files 28 28
Lines 2137 2137
========================================
Hits 1669 1669
Misses 407 407
Partials 61 61
Flags with carried forward coverage won't be shown. Click here to find out more. |
bytes32 userKey = bytes32(abi.encode(msg.sender)); | ||
(uint32 error, bytes memory ret) = HA.CallOffchain(userKey, req); | ||
|
||
if (error != 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct from a documentation perspective (matches the code) but I'm not sure if the code itself makes sense. Kevin, can you check this? I'm not sure why there's an "emit" followed by a "revert", or why it's splitting the error code and 'ret' string across two different events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a change in this PR but I noticed a typo in this file. In the "why is that" section you show the JSON-RPC request sent to the server, including a method field:
"method":"ASD97e0d7ba",
That should be:
"method":"97e0d7ba",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a couple of comments but it looks OK to me overall.
Co-authored-by: Riedl Kevin, Bsc. <[email protected]>
…ba into katie/hc-docs-add-example
📋 Add associated issues, tickets, docs URL here.
Overview
Added a brief explanation of the
fetchPrice
contractChanges
Describe your changes and implementation choices. More details make PRs easier to review.
Testing
n/a