Emit l2BlockNumber in the Resolved event #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #226 +/- ##
========================================
Coverage 41.31% 41.31%
========================================
Files 74 74
Lines 5001 5001
Branches 785 785
========================================
Hits 2066 2066
Misses 2828 2828
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. |
wsdt
approved these changes
Aug 8, 2024
mmontour1306
approved these changes
Aug 8, 2024
|
The new |
|
I will try to push this to the upstream. |
|
I have followed their contribution rule and created a Github issue for the discussion. ethereum-optimism#11409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Add associated issues, tickets, docs URL here.
Overview
Describe what your Pull Request is about in a few sentences.
To reduce the number of RPC calls needed to retrieve the
l2BlockNumbersubmitted with the state root in the game, I have added thel2BlockNumberand rootClaim to the event.This allows us to retrieve all necessary information for the withdrawal from our subgraph rather than making RPC calls to get the
l2BlockNumber.Here is how the current implementation works: https://github.com/bobanetwork/graphql-utils/pull/9/files Basically, we need to perform a for loop to find the game where its
l2BlockNumberis larger than the target value, and the previous game’sl2BlockNumberis smaller than the target value.Changes
Describe your changes and implementation choices. More details make PRs easier to review.
Testing
Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.
The tests are added