-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the rollup rpc timeout issue in op-challenger #225
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #225 +/- ##
========================================
Coverage 41.31% 41.31%
========================================
Files 74 74
Lines 5001 5001
Branches 785 785
========================================
Hits 2066 2066
Misses 2828 2828
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this looks like it might be worth trying to upstream?
This reverts commit 185b60d.
I tried to push this RPC timeout to the upstream, but Optimism rejected it. |
📋 Add associated issues, tickets, docs URL here.
Overview
Describe what your Pull Request is about in a few sentences.
The rollup calls in the op-challenger can fail without any error logs. This increases the RPC call waiting time and prints error messages.
Changes
Describe your changes and implementation choices. More details make PRs easier to review.
Testing
Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.