Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the rollup rpc timeout issue in op-challenger #225

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

boyuan-chen
Copy link

📋 Add associated issues, tickets, docs URL here.

Overview

Describe what your Pull Request is about in a few sentences.

The rollup calls in the op-challenger can fail without any error logs. This increases the RPC call waiting time and prints error messages.

Changes

Describe your changes and implementation choices. More details make PRs easier to review.

  • Add timeout configs

Testing

Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.31%. Comparing base (71ae762) to head (824e5bd).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #225   +/-   ##
========================================
  Coverage    41.31%   41.31%           
========================================
  Files           74       74           
  Lines         5001     5001           
  Branches       785      785           
========================================
  Hits          2066     2066           
  Misses        2828     2828           
  Partials       107      107           
Flag Coverage Δ
cannon-go-tests 81.92% <ø> (ø)
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests 26.72% <ø> (ø)
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests 44.03% <ø> (ø)
sdk-tests 37.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@boyuan-chen boyuan-chen temporarily deployed to op-stack-production August 6, 2024 22:05 — with GitHub Actions Inactive
Copy link

@jyellick jyellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this looks like it might be worth trying to upstream?

@boyuan-chen
Copy link
Author

LGTM, this looks like it might be worth trying to upstream?

I tried to push this RPC timeout to the upstream, but Optimism rejected it.

@boyuan-chen boyuan-chen merged commit bb82a9b into develop Aug 8, 2024
71 checks passed
@boyuan-chen boyuan-chen deleted the fix-op-challenger-timeout branch August 8, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants