Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use [email protected] for the integration test #178

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

boyuan-chen
Copy link

@boyuan-chen boyuan-chen commented Apr 17, 2024

📋 Add associated issues, tickets, docs URL here.

Overview

Describe what your Pull Request is about in a few sentences.

[email protected] requires the node version to be v18. This is a simple patch for the integration test. Once we pull from upstream, we will use the latest tag.

Changes

Describe your changes and implementation choices. More details make PRs easier to review.

  • Update pnpm version

Testing

Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.21%. Comparing base (41efa7c) to head (6096e1f).
Report is 3 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #178       +/-   ##
============================================
- Coverage    82.20%   28.21%   -54.00%     
============================================
  Files           10      168      +158     
  Lines         1068     7294     +6226     
  Branches         0     1311     +1311     
============================================
+ Hits           878     2058     +1180     
- Misses         159     5130     +4971     
- Partials        31      106       +75     
Flag Coverage Δ
cannon-go-tests 82.20% <ø> (ø)
chain-mon-tests 27.14% <ø> (?)
common-ts-tests 26.72% <ø> (?)
contracts-bedrock-tests 0.62% <ø> (?)
contracts-ts-tests 12.25% <ø> (?)
core-utils-tests 44.03% <ø> (?)
sdk-next-tests 38.59% <ø> (?)
sdk-tests 38.59% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 158 files with indirect coverage changes

@boyuan-chen boyuan-chen merged commit 4804686 into develop Apr 17, 2024
70 checks passed
@boyuan-chen boyuan-chen deleted the use-older-pnpm branch April 17, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants