Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update FAQ #171

Merged
merged 6 commits into from
Apr 16, 2024
Merged

chore: Update FAQ #171

merged 6 commits into from
Apr 16, 2024

Conversation

wsdt
Copy link
Collaborator

@wsdt wsdt commented Apr 15, 2024

No description provided.

@wsdt wsdt requested review from jyellick and souradeep-das April 15, 2024 17:48
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.21%. Comparing base (5dc0653) to head (c5efc9a).
Report is 1 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #171      +/-   ##
===========================================
- Coverage    28.28%   28.21%   -0.08%     
===========================================
  Files          157      168      +11     
  Lines         6946     7294     +348     
  Branches      1255     1311      +56     
===========================================
+ Hits          1965     2058      +93     
- Misses        4875     5130     +255     
  Partials       106      106              
Flag Coverage Δ
cannon-go-tests 82.20% <ø> (ø)
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests 26.72% <ø> (?)
contracts-bedrock-tests 0.62% <ø> (ø)
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests 44.03% <ø> (ø)
sdk-next-tests 38.59% <ø> (ø)
sdk-tests 38.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

Copy link

@jyellick jyellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think line 58/60 needs to be amended as well, as there are now at least a couple exchanges that integrate directly with Boba

.gitbook/FAQ.md Outdated Show resolved Hide resolved
@wsdt wsdt requested a review from boyuan-chen April 16, 2024 08:55
@wsdt
Copy link
Collaborator Author

wsdt commented Apr 16, 2024

LGTM, but I think line 58/60 needs to be amended as well, as there are now at least a couple exchanges that integrate directly with Boba

incorporated both comments, thx!

.gitbook/FAQ.md Outdated Show resolved Hide resolved
Co-authored-by: Jason Yellick <[email protected]>
@wsdt wsdt merged commit 539e2ce into develop Apr 16, 2024
1 of 16 checks passed
@wsdt wsdt deleted the wsdt/faq-docs branch April 16, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants