Update basic-ops docs #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyellick
commented
Apr 12, 2024
|
|
||
| ```javascript | ||
| import { iOVM_L1BlockNumber } from "@eth-optimism/contracts/L2/predeploys/iOVM_L1BlockNumber.sol"; | ||
| import { Lib_PredeployAddresses } from "@eth-optimism/contracts/libraries/constants/Lib_PredeployAddresses.sol"; | ||
| import { L1Block } from "@eth-optimism/contracts-bedrock/L2/L1Block.sol"; |
There was a problem hiding this comment.
@souradeep-das does this look right? I briefly tried to get this to build on my local machine, but ran into errors that I think are largely related to my incompetence.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #159 +/- ##
===========================================
+ Coverage 18.95% 28.21% +9.26%
===========================================
Files 158 168 +10
Lines 6226 7294 +1068
Branches 1311 1311
===========================================
+ Hits 1180 2058 +878
- Misses 4971 5130 +159
- Partials 75 106 +31
Flags with carried forward coverage won't be shown. Click here to find out more. |
souradeep-das
approved these changes
Apr 12, 2024
wsdt
approved these changes
Apr 12, 2024
Co-authored-by: Souradeep Das <[email protected]>
jyellick
force-pushed
the
jyellick/update-basic-ops-docs
branch
from
96a9246 to
948ff11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the basic-ops page to reflect Anchorage.