Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bridging-basics README #158

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

jyellick
Copy link

The existing README references fast bridging which no longer exists, along with Moonbeam, Avalanche, and Fantom.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.21%. Comparing base (a6aa63e) to head (1f82590).
Report is 2 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #158       +/-   ##
============================================
- Coverage    41.71%   28.21%   -13.50%     
============================================
  Files           74      168       +94     
  Lines         4898     7294     +2396     
  Branches       765     1311      +546     
============================================
+ Hits          2043     2058       +15     
- Misses        2749     5130     +2381     
  Partials       106      106               
Flag Coverage Δ
cannon-go-tests 82.20% <ø> (ø)
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests 26.72% <ø> (ø)
contracts-bedrock-tests 0.62% <ø> (?)
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests 44.03% <ø> (ø)
sdk-next-tests 38.59% <ø> (ø)
sdk-tests 38.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 94 files with indirect coverage changes

@@ -4,14 +4,14 @@ description: Learn more about the Boba Network Bridges

# Token Bridging

Although Boba Network is an L2 (and therefore fundamentally connected to Ethereum), it's also a separate blockchain system. App developers commonly need to move data and assets between Boba Network and Ethereum. We call the process of moving data and assets between the two networks "bridging".
Although Boba Network is an L2 (and therefore fundamentally connected to a L1), it's also a separate blockchain system. App developers commonly need to move data and assets between Boba Network and Ethereum or an alt-L1 like BNB Chain. We call the process of moving data and assets between the two networks "bridging".

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small grammar point here, inconsistency between "an L2" and "a L1".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed

@jyellick jyellick force-pushed the jyellick/update-bridge-basics-readme branch from 6001af1 to 1f82590 Compare April 16, 2024 02:28
@jyellick jyellick requested review from souradeep-das and wsdt April 16, 2024 02:29
@jyellick jyellick force-pushed the jyellick/update-bridge-basics-readme branch from 1f82590 to 8a0da8e Compare April 16, 2024 13:59
@jyellick jyellick merged commit 9059d57 into develop Apr 16, 2024
1 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants