fix: unify denom as BNB #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keefel
force-pushed
the
keefe/dev
branch
2 times, most recently
from
7158ecc to
eda2a02
Compare
unclezoro
reviewed
Feb 17, 2023
unclezoro
requested changes
Feb 17, 2023
added 2 commits
February 17, 2023 14:06
fynnss
reviewed
Feb 17, 2023
pythonberg1997
approved these changes
Feb 17, 2023
j75689
approved these changes
Feb 17, 2023
|
The readme need change as well. |
fynnss
approved these changes
Feb 17, 2023
unclezoro
approved these changes
Feb 17, 2023
This was referenced Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unify denom in all modules to BNB, BNB is the base denom, it has 18 decimals, so when we use Coin{Amount: 1e18, Denom: "BNB"}, it means 1 BNB.
Rationale
The denom in different modules is not unified, it causes confusion and error.
Example
NA
Changes
Notable changes: