feat: limit the interval for updating quota #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
approved these changes
Jun 14, 2023
fynnss
approved these changes
Jun 25, 2023
fynnss
reviewed
Jun 25, 2023
| store := ctx.KVStore(k.storeKey) | ||
| bz := make([]byte, 8) | ||
| binary.BigEndian.PutUint64(bz, timestamp) | ||
| store.Set(types.GetQuotaKey(bucketId), bz) |
There was a problem hiding this comment.
Can the quota update time be stored directly in bucketInfo? It didn't feel necessary to add a separate key
There was a problem hiding this comment.
Or, I think we should separate some frequently modified fields from bucketInfo as a separate key-value.
There was a problem hiding this comment.
the update frequency of quote is very low, or even no update at all.
currently, if there is no update, it will not be stored (just use bucket' creation time).
unclezoro
approved these changes
Jun 26, 2023
This was referenced Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will limit the interval for updating bucket read quota.
Rationale
If there is no limit, a user can change the quota smaller at anytime to pay less.
Example
NA
Changes
Notable changes: