Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add storage module #18

Merged
merged 22 commits into from
Feb 9, 2023
Merged

feat: add storage module #18

merged 22 commits into from
Feb 9, 2023

Conversation

fynnss
Copy link
Contributor

@fynnss fynnss commented Jan 4, 2023 •
edited
Loading

Description

The storage module used to manage and maintain the metadata of all the resources stored in SP.

Rationale

Changes

Notable changes:

  • Add basic message for bucket/object/group
  • Add basic message handle function

TODOs

  • Interact with payment module
  • Refactor code when interact with cross-chain
  • Add more test
  • Add events

@fynnss fynnss requested a review from RenRick January 4, 2023 02:31
@fynnss fynnss marked this pull request as draft January 4, 2023 02:32
@fynnss fynnss changed the title storage module impl feat: storage module impl Jan 4, 2023
@fynnss fynnss changed the base branch from master to develop January 4, 2023 02:33
@fynnss fynnss changed the title feat: storage module impl feat: add storage module Jan 6, 2023
@fynnss fynnss force-pushed the storage_module branch 5 times, most recently from 021f6e1 to 8ba26ce Compare January 17, 2023 08:49
owen-reorg
owen-reorg reviewed Jan 20, 2023
View reviewed changes
proto/bfs/storage/tx.proto Outdated
message MsgLeaveGroup {
option (cosmos.msg.v1.signer) = "creator";
string creator = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
string owner = 2 [(cosmos_proto.scalar) = "cosmos.AddressString"];

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

owen-reorg
owen-reorg reviewed Jan 20, 2023
View reviewed changes
x/storage/keeper/query.go Outdated
}

ctx := sdk.UnwrapSDKContext(goCtx)
// TODO(fynn): check if have permission

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

owen-reorg
owen-reorg reviewed Jan 20, 2023
View reviewed changes
x/storage/client/cli/tx.go
)

var (
DefaultRelativePacketTimeoutTimestamp = uint64((time.Duration(10) * time.Minute).Nanoseconds())

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

@fynnss fynnss requested a review from owen-reorg January 31, 2023 09:46
@fynnss fynnss merged commit 7783af4 into develop Feb 9, 2023
This was referenced Feb 10, 2023
Merged
Merged
@fynnss fynnss deleted the storage_module branch March 1, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RenRick RenRick RenRick approved these changes

@unclezoro unclezoro unclezoro approved these changes

@joeylichang joeylichang Awaiting requested review from joeylichang

@flywukong flywukong Awaiting requested review from flywukong

@owen-reorg owen-reorg Awaiting requested review from owen-reorg

@yutianwu yutianwu Awaiting requested review from yutianwu

Assignees
No one assigned
Labels
r4r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fynnss @yutianwu @unclezoro @RenRick @owen-reorg