feat: support delete bucket with non-zero charged read quota #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
approved these changes
Mar 24, 2023
fynnss
reviewed
Mar 24, 2023
| @@ -23,7 +23,7 @@ var ( | |||
| ErrSourceTypeMismatch = errors.Register(ModuleName, 1114, "Object source type mismatch") | |||
| ErrTooLargeObject = errors.Register(ModuleName, 1115, "Object payload size is too large") | |||
| ErrInvalidApproval = errors.Register(ModuleName, 1116, "Invalid approval of sp") | |||
| ErrBucketBillNotEmpty = errors.Register(ModuleName, 1117, "bucket bill is not empty") | |||
| ErrCharge = errors.Register(ModuleName, 1117, "charge error") | |||
There was a problem hiding this comment.
How about ErrChargeFailed ?
| } | ||
| // should only remain at most 2 flows: charged_read_quota fee and tax | ||
| if len(bill.Flows) > 2 { | ||
| return fmt.Errorf("unexpected left flow number: %d", len(bill.Flows)) |
There was a problem hiding this comment.
If this error occurs, how should the user handle it?
There was a problem hiding this comment.
It should never happen, unless we have a bug(e.g. there is still object in the bucket, but somehow it passes the check).
This was referenced Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously a bucket with a non-zero charged read quota cannot be deleted.
This PR supports that by changing the billing info in that transaction.
Rationale
Make it easier for users to delete a bucket. They don't need to update the charged read quota to zero first before deleting it.
Example
NA
Changes
Notable changes:
DeleteBucket