feat: Wrap MUI button and apply styles, references #1318 #1360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal for wrapping MUI components and applying styles as discussed and referenced in #1318. It wraps an MUI Button and applies our styles from the
GlobalTheme
.Please try using the component next to a regular MUI Button, all styles appear to be applied correctly to me and the component appears identical to an MUI button styled by the
GlobalTheme
I propose that we use styled components as this MUI has support out of the box and this is how MUI components are styled themselves.
This will also allow us to pretty much directly copy and paste styles out of the Global theme which should speed up the process.
I suggest we standardize on this approach going forward. That said I'm completely open to disucssion on the topic if anyone has strong opinions!
Once we've decided on the method of styling we'd like to use we can go forward and wrap all the necessary components.