Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode switcher before login and inside dashboard #1317

Open
gorkem-bwl opened this issue Dec 10, 2024 · 10 comments
Open

Dark mode switcher before login and inside dashboard #1317

gorkem-bwl opened this issue Dec 10, 2024 · 10 comments
Labels
design Design related frontend
Milestone

Comments

@gorkem-bwl
Copy link
Contributor

gorkem-bwl commented Dec 10, 2024

We need a dark mode switcher before logging in and inside the dashboard. Here is a good option: https://web.dev/patterns/theming/theme-switch

It can be added here for login:

image

And here for the dashboard:

image
@gorkem-bwl gorkem-bwl added design Design related frontend labels Dec 10, 2024
@gorkem-bwl gorkem-bwl added this to the 2.0.1 milestone Dec 10, 2024
@gorkem-bwl gorkem-bwl changed the title Dark mode switcher before login Dark mode switcher before login and inside dashboard Dec 10, 2024
@peterpardo
Copy link
Contributor

Hello! I can work on this.

In this issue, do we also include the functionality of the dark mode switcher?

@gorkem-bwl
Copy link
Contributor Author

Hi Peter. Yes, we need that functionality. Let me know if you still would like to work on it.

@peterpardo
Copy link
Contributor

Got it. I can work on this one.

@peterpardo
Copy link
Contributor

For the dark mode switch in the Dashboard, do you want to place it on the left of the ellipsis vertical icon?

@ajhollid
Copy link
Collaborator

For the dark mode switch in the Dashboard, do you want to place it on the left of the ellipsis vertical icon?

Hi @peterpardo ,

Yes I believe that is the idea

@gorkem-bwl
Copy link
Contributor Author

@peterpardo it might be a bit tricky so please share you screenshots/videos here as you progress :)

@peterpardo
Copy link
Contributor

I was researching dark mode in Material UI, and I came across this approach: https://mui.com/material-ui/customization/dark-mode/#dark-mode-only

Then while navigating through the source code, I saw this comment regarding changing how we implement themes in the app.
image

Do we want to include these changes in this issue as well?

@gorkem-bwl
Copy link
Contributor Author

gorkem-bwl commented Dec 13, 2024

If it is directly related to this issue, you can include it. If you can separate them (e.g implement #1317 and then move on to the one commented), that is easier to review and merge I assume.

@peterpardo
Copy link
Contributor

Got it. I think for this issue, we can add the dark mode switcher without the functionality for now. Then create another PR for the functionality which will include the TODO in the comment. What do you think?

@gorkem-bwl
Copy link
Contributor Author

Got it. I think for this issue, we can add the dark mode switcher without the functionality for now. Then create another PR for the functionality which will include the TODO in the comment. What do you think?

Let's go then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design related frontend
Projects
None yet
Development

No branches or pull requests

3 participants