-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode switcher before login and inside dashboard #1317
Comments
Hello! I can work on this. In this issue, do we also include the functionality of the dark mode switcher? |
Hi Peter. Yes, we need that functionality. Let me know if you still would like to work on it. |
Got it. I can work on this one. |
For the dark mode switch in the Dashboard, do you want to place it on the left of the |
Hi @peterpardo , Yes I believe that is the idea |
@peterpardo it might be a bit tricky so please share you screenshots/videos here as you progress :) |
I was researching dark mode in Material UI, and I came across this approach: https://mui.com/material-ui/customization/dark-mode/#dark-mode-only Then while navigating through the source code, I saw this comment regarding changing how we implement themes in the app. Do we want to include these changes in this issue as well? |
If it is directly related to this issue, you can include it. If you can separate them (e.g implement #1317 and then move on to the one commented), that is easier to review and merge I assume. |
Got it. I think for this issue, we can add the dark mode switcher without the functionality for now. Then create another PR for the functionality which will include the TODO in the comment. What do you think? |
Let's go then! |
We need a dark mode switcher before logging in and inside the dashboard. Here is a good option: https://web.dev/patterns/theming/theme-switch
It can be added here for login:
And here for the dashboard:
The text was updated successfully, but these errors were encountered: