Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve video filenames #397

Merged

Conversation

rafaellehmkuhl
Copy link
Member

Fix #387

@rafaellehmkuhl rafaellehmkuhl requested a review from rjehangir July 31, 2023 14:00
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_2023-07-31-11-36-10-909_com android chrome-edit

I believe that there is something wrong with the string

@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Jul 31, 2023

I believe that there is something wrong with the string

The string is correct. Your terminal is probably missing Unicode characters. We are using alternative colon and slash from Unicode.

@patrickelectric
Copy link
Member

I believe that there is something wrong with the string

The string is correct. Your terminal is probably missing Unicode characters. We are using alternative colon and slash from Unicode.

It just feels weird not using normal ascii characters, like : https://theasciicode.com.ar/ascii-printable-characters/colon-ascii-code-58.html

@rafaellehmkuhl
Copy link
Member Author

I believe that there is something wrong with the string

The string is correct. Your terminal is probably missing Unicode characters. We are using alternative colon and slash from Unicode.

It just feels weird not using normal ascii characters, like : https://theasciicode.com.ar/ascii-printable-characters/colon-ascii-code-58.html

Regular colon is not allowed as part of a filename on Windows, and regular slash is not allowed on any platform.

@patrickelectric patrickelectric merged commit 3830b87 into bluerobotics:master Jul 31, 2023
@rafaellehmkuhl rafaellehmkuhl deleted the improve-video-filenames branch July 31, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video filenames are not much descriptive
2 participants