Don't auto-remap and disable forwarding while configuring joystick #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
approved these changes
Jul 28, 2023
| const inputOldValue = oldInputMapping[index] | ||
| // For the index that previously holded the selected value, use the former value of the modified index | ||
| const undefinedInput = { protocol: undefined, value: undefined } | ||
| // Let unnassigned indexes that previously holded the selected value |
There was a problem hiding this comment.
is this "Let" misplaced? I'm having a hard time interpreting this sentence.
plus "hold is an irregular verb, so I think the correct form here would be "held" 🤔
There was a problem hiding this comment.
It's indeed confusing.
Changing to Let at 'unnassigned' state indexes that previously held the selected value.
rafaellehmkuhl
force-pushed
the
dont-auto-remap
branch
from
bbc7851 to
0f1ebb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #381
Fix #382