webrtc-manager: Assing 'motion' contentHint to video tracks #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const videoTracks = this.mediaStream.value.getVideoTracks().filter((t) => t.kind === 'video') | ||
| videoTracks.forEach((track) => { | ||
| if (!('contentHint' in track)) { | ||
| console.error('MediaStreamTrack contentHint attribute not supported.') |
There was a problem hiding this comment.
shouldn't this be in the other way around ? We are checking for 'contentHint' but at the same time we are setting it nevertheless.
There was a problem hiding this comment.
Yeah, here's a reference
There was a problem hiding this comment.
We first check if the field is supported, and if not, we don't assign. Although I forgot a return there. Adding and merging.
rafaellehmkuhl
force-pushed
the
add-video-content-hint
branch
from
c82a4e9 to
da37ec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It helps video content perform better on low bandwidth situations.
More on that here: https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/contentHint