Fix infinite loop on the alerter #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/widgets/Alerter.vue
Outdated
| @@ -14,7 +14,7 @@ | |||
| class="expanded-alerts-bar absolute w-full p-2 transition-all rounded top-12 max-h-[30vh] overflow-y-auto text-slate-50 scrollbar-hide bg-slate-800/75 select-none flex flex-col" | |||
| :class="{ 'opacity-0 invisible': !isShowingExpandedAlerts }" | |||
| > | |||
| <div v-for="(alert, i) in alertStore.sortedAlerts.reverse()" :key="alert.time_created.toISOString()"> | |||
| <div v-for="(alert, i) in [...alertStore.sortedAlerts].reverse()" :key="alert.time_created.toISOString()"> | |||
There was a problem hiding this comment.
It would be nice to have a comment explaining the copy to avoid someone cleaning the code and adding the bug back.
Reverting it in place causes an infinite mutation loop in the list (and crashes the app).
rafaellehmkuhl
force-pushed
the
crash-fix
branch
from
3cc0d69 to
3820bc1
Compare
patrickelectric
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #364