Add mini-widgets #356
Merged
Add mini-widgets #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
requested review from
rjehangir,
Williangalvani,
joaoantoniocardoso and
ES-Alexander
rafaellehmkuhl
force-pushed
the
add-bar-widgets
branch
6 times, most recently
from
3a64037 to
c6fb58b
Compare
rafaellehmkuhl
force-pushed
the
add-bar-widgets
branch
from
c6fb58b to
5ca9b93
Compare
Merged
|
Needs rebase |
rafaellehmkuhl
force-pushed
the
add-bar-widgets
branch
from
5ca9b93 to
95837aa
Compare
This package allows usage of many `VueUse` composables that involve some calculation
This package adds draggable 1D list items.
Don't overflow by default.
- Change colors - Add padding
- Simplify management - Merge store with regular widgets - Use new `vue-draggable-plus` library - Only allow changes in edit-mode - Use drag from/to containers to add and remove widgets - Fix add button disappearing - Fix not being able to add to containers with widgets already
rafaellehmkuhl
force-pushed
the
add-bar-widgets
branch
from
95837aa to
d598e36
Compare
Done. |
ES-Alexander
approved these changes
Jun 22, 2023
patrickelectric
approved these changes
Jun 23, 2023
| loadFonts() | ||
|
|
||
| const app = createApp(App) | ||
| app.component('FontAwesomeIcon', FontAwesomeIcon) |
There was a problem hiding this comment.
I'm not a fan of mixing different icons source, it'll end up in different icons style and guidelines, that just make the interface inconsistency.
There was a problem hiding this comment.
We should discuss it at some point, for sure. The problem was that MDI misses several icons that we need.
Some like the depth one I needed to manually do in fact.
In the very end, we should try to make mostly or all of them.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-06-15.at.14.10.21.mov
To be merged after #355.
Fix #339.