Fix Hot Reload on Electron #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously used version was from 2 years ago and had problems in the Hot Module Replacement functionality.
|
Converted to draft as its breaking the CI 🫠 |
rafaellehmkuhl
force-pushed
the
some-plumbing-electron-work
branch
from
b1dc119 to
3f3691f
Compare
rafaellehmkuhl
force-pushed
the
some-plumbing-electron-work
branch
from
3f3691f to
e8dea79
Compare
|
@ArturoManzoli everything is now working! |
ArturoManzoli
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Hot Module Replacement functionality on Electron development.
Kapture.2024-10-10.at.14.45.01.mp4
This can be easily changed with the following: choose some component in the screen, like the
Alerter.vue, and change its background color. You will see that before this patch it doesn't change live, and instead one needs to reload the vite server.I originally planned to replace
vite-plugin-electronwithelectron-vite, which is better maintained, better documented and simpler to use, but I got the former to work, so I think we can stick with it for a while and change it only if we find some wall.