joystick: Allow user to disable the joystick #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturoManzoli
requested changes
Sep 16, 2024
There was a problem hiding this comment.
1- Maybe the message "Joystick forwarding" could be replaced with something more intuitive for new users, such as "Enable joystick", "Enable joystick communications" or "Pause joystick commands".
Even though "Joystick forwarding" is the best term in a technical perspective, it may not mean much inexperienced users.
2- The v-switch is more visible if the prop "color="white" is set.
When it has this prop, the 'on' state is highlighted:
rafaellehmkuhl
force-pushed
the
allow-disabling-joystick
branch
from
2b91921 to
44c23d8
Compare
ArturoManzoli
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kapture.2024-09-13.at.12.28.29.mp4
Fix #1311