Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn users when chunks are lost #1243

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Warn users when chunks are lost #1243

merged 5 commits into from
Aug 12, 2024

Conversation

ArturoManzoli
Copy link
Contributor

@ArturoManzoli ArturoManzoli commented Aug 12, 2024 •
edited
Loading

Implementation:

  • Quick feedback using snackbar messages that do not require user interaction;
  • Extended visual feedback when 5 or more consecutive chunks are lost or 5% of the video has lost chunks;
  • Added an option on video configurations so the user can choose between auto and manual video processing;

Closes #1228

@ArturoManzoli ArturoManzoli force-pushed the 1228-Cockpit-should-warn-when-chunks-are-lost branch from aa68459 to 109767f Compare August 12, 2024 20:00
@ArturoManzoli ArturoManzoli force-pushed the 1228-Cockpit-should-warn-when-chunks-are-lost branch from 109767f to ffeb3b6 Compare August 12, 2024 22:59
@rafaellehmkuhl rafaellehmkuhl merged commit ed79eb3 into bluerobotics:master Aug 12, 2024
8 checks passed
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaellehmkuhl rafaellehmkuhl rafaellehmkuhl approved these changes

Assignees
No one assigned
Labels
docs-needed Change needs to be documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cockpit should warn when video chunks are lost, but with no need of user interaction
3 participants
@ArturoManzoli @rafaellehmkuhl @ES-Alexander