Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Add image and link to online page #1108

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

patrickelectric
Copy link
Member

No description provided.

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proportions seen odd, don't you think?

image

The logo got very small with respect to everything, almost as if it was put there by mistake.

Also, I prefer the old vertical logo, which is more in pattern with what we see in most repositories.

The "screenshot" also seems to me like it should be from an actual underwater image. The paint adds too much information and the actual application ends up being just marginal near it.

Copy link
Contributor

@ArturoManzoli ArturoManzoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did like the interface with the art on it. It expresses well what cockpit is made for.
Manuals and readmes are the place where we can get abstract with the product and its elements for marketing purposes.

About the logo, I agree that increasing the size a bit will be better for the layout.

Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
@patrickelectric
Copy link
Member Author

Changed to be bigger:

image

The problem of using the vertical version is that the text gets moved and it's gets really weird IMO.

@rafaellehmkuhl rafaellehmkuhl self-requested a review July 15, 2024 20:09
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickelectric can you add the new banner but keep the old one in the repository?

@patrickelectric
Copy link
Member Author

@patrickelectric can you add the new banner but keep the old one in the repository?

It's not being used, what is the point ? If we want in the future we can just get the file in.

@rafaellehmkuhl rafaellehmkuhl merged commit cbdab3b into bluerobotics:master Jul 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants