[legacy-framework] Add Persistent layout to new app template with <Layout> and getLayout()
#897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thank you!! I pushed a commit that adds all the Typescript stuff |
flybayer
changed the title
<Layout> and getLayout()
This was referenced Aug 19, 2020
itsdillon
changed the title
<Layout> and getLayout()<Layout> and getLayout()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: blitz-js/legacy-framework#637
What are the changes and their implications?
This introduces a new
Layoutcomponent as suggested in blitz-js/legacy-framework#637. I've attempted to follow the suggestion in the linked blog post as well as the guide from the issue. Unfortunately my TypeScript isn't too hot, so I'm not sure where to take it from here. But hoping this may serve as a good starting point.Checklist