Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for long chain CSG operations causing WASM heap out of memory. #84

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

ConorStokes
Copy link
Contributor

A fix for the issue encountered at https://github.com/bldrs-ai/test-models-private/issues/12 where models with very long chains of CSG operations where a single complex mesh had small subtractions repeated on it over and over would cause an out of memory error on the WASM heap because there was too much geometry being memoized.

We now drop memoizations of boolean result operands when they are not currently geometry in the scene, which means they will not take up memory apart from temporary memory during the actual boolean operation.

  of a large model.
* We did this by deleting boolean result geometry if operand was not part
  of the scene.
@ConorStokes ConorStokes merged commit fb0136f into bldrs-ai:main Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants