Fix for long chain CSG operations causing WASM heap out of memory. #84
+69
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for the issue encountered at https://github.com/bldrs-ai/test-models-private/issues/12 where models with very long chains of CSG operations where a single complex mesh had small subtractions repeated on it over and over would cause an out of memory error on the WASM heap because there was too much geometry being memoized.
We now drop memoizations of boolean result operands when they are not currently geometry in the scene, which means they will not take up memory apart from temporary memory during the actual boolean operation.