Issue 4 seestrasse #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ifc/ifc_geometry_extraction.ts
Outdated
| try { | ||
| transparency = style.Transparency ?? transparency | ||
| } catch (e) { | ||
| // This is hiding a version difference with IFC 2x3 |
There was a problem hiding this comment.
Please add a 'TODO(author)' or 'TODO(gh issue-ref)' for here and below, about resolving schema skew
pablo-mayrgundter
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the initial issue with the model https://github.com/bldrs-ai/test-models-private/issues/4 where transparency and specular from the material not being supplied for IFC 2X3 trips up the geometry extraction/material export to gltf code.