-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conway-geom integration + Geometry Extraction + Tests #8
conway-geom integration + Geometry Extraction + Tests #8
Conversation
…n tests + Finalized geometry extraction class for first pass.
Going to tag this and #4 as draft pending update from web-ifc. |
…_geom_integration
…_geom_integration
@pablo-mayrgundter PTAL New changes notes:
** I am currently only testing the geometry code that is being used, though things are much neater now with the refactor and I am in position to test more IFC files. On subsequent PRs, any geometry API functions that are being used will have accompanying tests in Typescript (Conway) here and native (Conway-Geom). |
…tory and put files in the right places.
…sync create() + make extract return geometry
@pablo-mayrgundter PTAL - should compile and run on Windows + Mac OS |
These changes, along with the PR for conway-geom, enable geometry extraction via TypeScript. Currently, full extraction is possible on index.ifc. Future work is adding more transforms to the Geometry Extraction class.
Ref: #Share 669