Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conway-geom integration + Geometry Extraction + Tests #8

Merged
merged 34 commits into from
May 8, 2023

Conversation

nickcastel50
Copy link
Contributor

  • Added conway-geom as a new dependency to the project.
  • Implemented Geometry extraction via the new conway-geom Typescript API.
  • Added tests for geometry extraction
  • OBJ, GLTF + GLB + Draco round tripping via Typescript.
  • Coding style now conforming to Google style guide (K&R).

These changes, along with the PR for conway-geom, enable geometry extraction via TypeScript. Currently, full extraction is possible on index.ifc. Future work is adding more transforms to the Geometry Extraction class.

Ref: #Share 669

@nickcastel50 nickcastel50 added the enhancement New feature or request label Apr 17, 2023
@pablo-mayrgundter
Copy link
Member

Going to tag this and #4 as draft pending update from web-ifc.

@pablo-mayrgundter pablo-mayrgundter self-assigned this Apr 19, 2023
@pablo-mayrgundter pablo-mayrgundter changed the title conway-geom integration + Geometry Extraction + Tests DRAFT: conway-geom integration + Geometry Extraction + Tests Apr 19, 2023
@nickcastel50
Copy link
Contributor Author

@pablo-mayrgundter PTAL

New changes notes:

  • Updated Conway-Geom dependency
  • TS API now reentrant (first pass)
  • Code style + formatting now passes new linter checks

** I am currently only testing the geometry code that is being used, though things are much neater now with the refactor and I am in position to test more IFC files. On subsequent PRs, any geometry API functions that are being used will have accompanying tests in Typescript (Conway) here and native (Conway-Geom).

@nickcastel50 nickcastel50 changed the title DRAFT: conway-geom integration + Geometry Extraction + Tests conway-geom integration + Geometry Extraction + Tests Apr 26, 2023
@nickcastel50
Copy link
Contributor Author

@pablo-mayrgundter PTAL - should compile and run on Windows + Mac OS

@nickcastel50 nickcastel50 merged commit a46bad9 into bldrs-ai:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Closed PRs
Development

Successfully merging this pull request may close these issues.

2 participants